From patchwork Wed Sep 9 08:38:04 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rasmus Villemoes X-Patchwork-Id: 515757 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id EBCEA1402B7 for ; Wed, 9 Sep 2015 18:39:39 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b=ale07xXo; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754580AbbIIIja (ORCPT ); Wed, 9 Sep 2015 04:39:30 -0400 Received: from mail-la0-f43.google.com ([209.85.215.43]:33929 "EHLO mail-la0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753240AbbIIIi2 (ORCPT ); Wed, 9 Sep 2015 04:38:28 -0400 Received: by laeb10 with SMTP id b10so2058908lae.1 for ; Wed, 09 Sep 2015 01:38:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6d/zoLsRL8qDoY52+YxvpIfLGTh9Fq6TcApI7WGtO2o=; b=ale07xXomMUkisEYeLF0Yxa4vFPRtlvM7lAy5dqwIGNx5kjbwdHdF0n1ahqzLff/Dg FS7bqXbIGr6UJGZpTc23zMs1Xm94kiG+py5cllc9LnVoPH+lvhV0h4sTCmU2PYVpZy4p HsgbZRov9IQXIHPElpQySifxD5Mjww0xlDR7I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6d/zoLsRL8qDoY52+YxvpIfLGTh9Fq6TcApI7WGtO2o=; b=SBQ6/rC5DuKUVSi+k01hfW+puVIBuyRAZIFA8lMZ8HiF/6gYhnlNrPThf2eCuRL4jv mYA3nUWF4QZhNi8f/sltfyOGp6tKG1R0VQG+StlzQnWvsBtinGJivP43kIMVSwLLkoOv V6ivECAhtnBfbKBVFVkj0UmYSyViu6c8ypqTwUg4DTQBKiQmcrsg3VR+vi6Srg3Kc+jO P4AnF+rS7ZF4TfHiHB4ziFLpBxFrk6uPo2xHwR7wQZDVcMHhQkmVpMfrjykdzXLnuIxo OwneSxExhR6/tCcTOYoOJFWGkGxBDeAn6Y2rWJU30UZdhxUlSytqVxItUSvJJL62DyxU K7aw== X-Gm-Message-State: ALoCoQnRJC1LjxeChDJKFAyBBJAFnZIz93+87tT2VXsdXRStnugkJYnSg1uuNGD1mlwXT+SNbnUS X-Received: by 10.152.181.2 with SMTP id ds2mr7233376lac.48.1441787906914; Wed, 09 Sep 2015 01:38:26 -0700 (PDT) Received: from spencer.imf.au.dk ([130.225.20.51]) by smtp.gmail.com with ESMTPSA id wv7sm457286lbb.45.2015.09.09.01.38.26 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Sep 2015 01:38:26 -0700 (PDT) From: Rasmus Villemoes To: Sebastian Hesselbarth Cc: Rasmus Villemoes , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/4] net: mv643xx_eth: use kzalloc Date: Wed, 9 Sep 2015 10:38:04 +0200 Message-Id: <1441787886-7214-4-git-send-email-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.1.3 In-Reply-To: <1441787886-7214-1-git-send-email-linux@rasmusvillemoes.dk> References: <1441787886-7214-1-git-send-email-linux@rasmusvillemoes.dk> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The double memset is a little ugly; using kzalloc avoids it altogether. Signed-off-by: Rasmus Villemoes --- drivers/net/ethernet/marvell/mv643xx_eth.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c index d52639bc491f..960169efe636 100644 --- a/drivers/net/ethernet/marvell/mv643xx_eth.c +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c @@ -1859,14 +1859,11 @@ oom: return; } - mc_spec = kmalloc(0x200, GFP_ATOMIC); + mc_spec = kzalloc(0x200, GFP_ATOMIC); if (mc_spec == NULL) goto oom; mc_other = mc_spec + (0x100 >> 2); - memset(mc_spec, 0, 0x100); - memset(mc_other, 0, 0x100); - netdev_for_each_mc_addr(ha, dev) { u8 *a = ha->addr; u32 *table;