From patchwork Wed Sep 9 08:38:03 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rasmus Villemoes X-Patchwork-Id: 515758 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 8FAE51402B7 for ; Wed, 9 Sep 2015 18:40:00 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b=fbEEWlcg; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754545AbbIIIj0 (ORCPT ); Wed, 9 Sep 2015 04:39:26 -0400 Received: from mail-la0-f51.google.com ([209.85.215.51]:36757 "EHLO mail-la0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753238AbbIIIi1 (ORCPT ); Wed, 9 Sep 2015 04:38:27 -0400 Received: by lanb10 with SMTP id b10so1977295lan.3 for ; Wed, 09 Sep 2015 01:38:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4679mv2PUD+iXeIbDBHhPSYRVptRLUm1hIRtP4pPbdw=; b=fbEEWlcgepIDJDlC1dXb65aHIIfcB+Q63t2pQBh7pnQ8cH2D5V3P15yp/pwDeMwct6 ekPPRb3I0iq8HcGppTns5gywwNFaiZklWCebJ2tdS3H6GdA/m2sUwMWJhR8FSNkODom6 ARck/XbbbF+9CLQQq4phUh4P6s5Uudh46sWEE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4679mv2PUD+iXeIbDBHhPSYRVptRLUm1hIRtP4pPbdw=; b=j2e1ctSneHehkKsYQVbgHDG9RZnDFA6VR+yYVfA3KhV978aGxOn56Ubxj4MwrkOmB3 JGj4+oBD/Q4/qbEK8ORZa9JHyx2p2+odGzYXcDLpkPyQhpGapozhylLvI8/rVaR/UWNB pEG4uAtMSSO8pldoOkTYTLGe8Wyevjx5e1XvqilXiWICW2Qlj4Q6cWfT5lqcQatIUppz QtAYm6q+STIzZrmHVevf0brbPwRrvZ8KVCNJAyisFU92E10elctYDsP3A+LxSABfopzr fsFaNgPt3IiIEq329/nWwpPcNdpX2xFcDLYXVpzzHVNOrtQQY3pvu/2ysKIRgoiLZOpH 8G8w== X-Gm-Message-State: ALoCoQkYCyvK7cj74YXY11Dhk6WEIIrESqgNiUPgKoZzzM/CIpyf9XA078bRk8NqOjIbUsfwF6Q2 X-Received: by 10.152.27.230 with SMTP id w6mr15879715lag.63.1441787906039; Wed, 09 Sep 2015 01:38:26 -0700 (PDT) Received: from spencer.imf.au.dk ([130.225.20.51]) by smtp.gmail.com with ESMTPSA id wv7sm457286lbb.45.2015.09.09.01.38.25 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Sep 2015 01:38:25 -0700 (PDT) From: Rasmus Villemoes To: Guo-Fu Tseng Cc: Rasmus Villemoes , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/4] net: jme: use kzalloc() instead of kmalloc+memset Date: Wed, 9 Sep 2015 10:38:03 +0200 Message-Id: <1441787886-7214-3-git-send-email-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.1.3 In-Reply-To: <1441787886-7214-1-git-send-email-linux@rasmusvillemoes.dk> References: <1441787886-7214-1-git-send-email-linux@rasmusvillemoes.dk> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Using kzalloc saves a tiny bit on .text. Signed-off-by: Rasmus Villemoes --- drivers/net/ethernet/jme.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c index 6e9a792097d3..060dd3922974 100644 --- a/drivers/net/ethernet/jme.c +++ b/drivers/net/ethernet/jme.c @@ -583,7 +583,7 @@ jme_setup_tx_resources(struct jme_adapter *jme) atomic_set(&txring->next_to_clean, 0); atomic_set(&txring->nr_free, jme->tx_ring_size); - txring->bufinf = kmalloc(sizeof(struct jme_buffer_info) * + txring->bufinf = kzalloc(sizeof(struct jme_buffer_info) * jme->tx_ring_size, GFP_ATOMIC); if (unlikely(!(txring->bufinf))) goto err_free_txring; @@ -592,8 +592,6 @@ jme_setup_tx_resources(struct jme_adapter *jme) * Initialize Transmit Descriptors */ memset(txring->alloc, 0, TX_RING_ALLOC_SIZE(jme->tx_ring_size)); - memset(txring->bufinf, 0, - sizeof(struct jme_buffer_info) * jme->tx_ring_size); return 0; @@ -845,7 +843,7 @@ jme_setup_rx_resources(struct jme_adapter *jme) rxring->next_to_use = 0; atomic_set(&rxring->next_to_clean, 0); - rxring->bufinf = kmalloc(sizeof(struct jme_buffer_info) * + rxring->bufinf = kzalloc(sizeof(struct jme_buffer_info) * jme->rx_ring_size, GFP_ATOMIC); if (unlikely(!(rxring->bufinf))) goto err_free_rxring; @@ -853,8 +851,6 @@ jme_setup_rx_resources(struct jme_adapter *jme) /* * Initiallize Receive Descriptors */ - memset(rxring->bufinf, 0, - sizeof(struct jme_buffer_info) * jme->rx_ring_size); for (i = 0 ; i < jme->rx_ring_size ; ++i) { if (unlikely(jme_make_new_rx_buf(jme, i))) { jme_free_rx_resources(jme);