From patchwork Thu Sep 3 06:00:30 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 513844 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 08251140285 for ; Thu, 3 Sep 2015 16:00:57 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=dE86N5sG; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753834AbbICGAk (ORCPT ); Thu, 3 Sep 2015 02:00:40 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:33415 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752040AbbICGAj (ORCPT ); Thu, 3 Sep 2015 02:00:39 -0400 Received: by pacex6 with SMTP id ex6so30818485pac.0; Wed, 02 Sep 2015 23:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=ybtXJB5XUY9ce1m4KmRHlPZNW5LY40O+KkmLdNCVSZY=; b=dE86N5sGZv6fDr7zY6dXerYxY1Nu2MN0cIrWQsCPFXdQVfkZu8YUu1KtvAfmg8DeL3 0c3kzysABpas+qkkGeDBm0Coz8H7EwnT1ABqOz8Sn0+ijiQkqDi5spZmqjbiN4hKDGU2 oTclrx/C4wAejkmk+6WDWP+du3eK5CHSnccM5RVQSoo21PhZjV2vkPM1Je1fjmXiUVyi DF/NypnXCPe2iySSMlGcMDty6Jv8T4q5oO3Tw59LpySR2moHm/s1xguxWWwRaQtUTOQZ 4cGnTx/Z3PoFVFLOdZo/R87w1I5sETP5kTzAEY2URytlH78kKRYhuYeJdtrXXbSBcouM QVWw== X-Received: by 10.68.68.233 with SMTP id z9mr63399347pbt.140.1441260039068; Wed, 02 Sep 2015 23:00:39 -0700 (PDT) Received: from localhost.localdomain ([122.175.59.239]) by smtp.gmail.com with ESMTPSA id xg3sm23735626pbb.64.2015.09.02.23.00.36 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 02 Sep 2015 23:00:38 -0700 (PDT) From: Sudip Mukherjee To: "David S. Miller" Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Sudip Mukherjee Subject: [PATCH] net: wan: sbni: fix device usage count Date: Thu, 3 Sep 2015 11:30:30 +0530 Message-Id: <1441260030-8141-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org dev_get_by_name() will increment the usage count if the matching device is found. But we were not decrementing the count if we have got the device and the device is non-active. Signed-off-by: Sudip Mukherjee --- drivers/net/wan/sbni.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wan/sbni.c b/drivers/net/wan/sbni.c index 758c4ba..8fef8d8 100644 --- a/drivers/net/wan/sbni.c +++ b/drivers/net/wan/sbni.c @@ -1358,6 +1358,8 @@ sbni_ioctl( struct net_device *dev, struct ifreq *ifr, int cmd ) if( !slave_dev || !(slave_dev->flags & IFF_UP) ) { netdev_err(dev, "trying to enslave non-active device %s\n", slave_name); + if (slave_dev) + dev_put(slave_dev); return -EPERM; }