From patchwork Mon Aug 17 05:58:39 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Noam Camus X-Patchwork-Id: 507759 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 32233140134 for ; Mon, 17 Aug 2015 16:17:05 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752663AbbHQGRA (ORCPT ); Mon, 17 Aug 2015 02:17:00 -0400 Received: from mail-db3on0074.outbound.protection.outlook.com ([157.55.234.74]:64314 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752562AbbHQGQ7 (ORCPT ); Mon, 17 Aug 2015 02:16:59 -0400 Received: from AM3PR02CA0047.eurprd02.prod.outlook.com (10.242.240.47) by VI1PR02MB1152.eurprd02.prod.outlook.com (10.163.164.16) with Microsoft SMTP Server (TLS) id 15.1.231.21; Mon, 17 Aug 2015 06:02:15 +0000 Received: from AM1FFO11FD027.protection.gbl (2a01:111:f400:7e00::114) by AM3PR02CA0047.outlook.office365.com (2a01:111:e400:8800::47) with Microsoft SMTP Server (TLS) id 15.1.231.21 via Frontend Transport; Mon, 17 Aug 2015 06:02:15 +0000 Authentication-Results: spf=fail (sender IP is 212.179.42.66) smtp.mailfrom=ezchip.com; synopsys.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of ezchip.com does not designate 212.179.42.66 as permitted sender) receiver=protection.outlook.com; client-ip=212.179.42.66; helo=ezex10.ezchip.com; Received: from ezex10.ezchip.com (212.179.42.66) by AM1FFO11FD027.mail.protection.outlook.com (10.174.64.216) with Microsoft SMTP Server (TLS) id 15.1.243.9 via Frontend Transport; Mon, 17 Aug 2015 06:02:14 +0000 Received: from localhost.localdomain (10.1.3.132) by ezex10.ezchip.com (10.1.1.4) with Microsoft SMTP Server (TLS) id 14.3.224.2; Mon, 17 Aug 2015 09:01:51 +0300 From: Noam Camus To: , CC: , , , , Noam Camus Subject: [v1 6/6] NET: nps_enet: minor namespace cleanup Date: Mon, 17 Aug 2015 08:58:39 +0300 Message-ID: <1439791119-26892-7-git-send-email-noamc@ezchip.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1439791119-26892-6-git-send-email-noamc@ezchip.com> References: <1439791119-26892-1-git-send-email-noamc@ezchip.com> <1439791119-26892-2-git-send-email-noamc@ezchip.com> <1439791119-26892-3-git-send-email-noamc@ezchip.com> <1439791119-26892-4-git-send-email-noamc@ezchip.com> <1439791119-26892-5-git-send-email-noamc@ezchip.com> <1439791119-26892-6-git-send-email-noamc@ezchip.com> MIME-Version: 1.0 X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.000.1202-21750.005 X-TM-AS-Result: No--1.375900-8.000000-31 X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; AM1FFO11FD027; 1:NJxQBwpnMIFhraO7hL/Z0airDGftacpAnNXNxzc3skvZGFCDzgfHx/4IkbihMgtc8X7V+9iBsBLhJszYRqOk9ecP6XAENVWc2mjcGUarRRZD0BgU3ga5bQa2l2YDh9p/UvaZmTx340Pv1vhmApPe2+mT7DzK/wQuY25OAnjtV24RIAx3ahU2f8pDioJdGq6DrX1bi5DQpFvO9EHPzg71vG7frq3km9eUoCUR3S0Z9xyY+37bi4GmbIesqoPwFUewWT6fyWyoniZSi8wITIayukyr6RCQPhntdUrxtjeVWqyl9XS9CekZ3c6AiKP4WWq2jncSfqMlbVXYN3JzAJHVg/X40IaeeeZPdtN6FDCTXFukxfh8gMK9ZEKXjwPL9kWL X-Forefront-Antispam-Report: CIP:212.179.42.66; CTRY:IL; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(2980300002)(3050300001)(339900001)(189002)(199003)(85426001)(105606002)(50986999)(46102003)(5003940100001)(5001970100001)(77096005)(2950100001)(189998001)(107886002)(50466002)(33646002)(5001860100001)(76176999)(50226001)(92566002)(48376002)(5001830100001)(4001540100001)(106466001)(62966003)(77156002)(87936001)(86362001)(104016003)(5001770100001)(47776003)(229853001)(64706001)(93886004)(49486002)(6806004)(19580405001)(36756003)(19580395003)(4001430100001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR02MB1152; H:ezex10.ezchip.com; FPR:; SPF:Fail; PTR:ezmail.ezchip.com; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; VI1PR02MB1152; 2:sd7Tu39suWHgZTmyjioP83J0yNsRRl6N/8gHr75ejqJ/EOd+yGVAhRK+j9ozplXcDhMfODwm8YfrzgS/0lDOtuUngzub4GhOGx/5ikaZAFoVEVQG42j6nQYxnPBpCofxW9SNGVWFVLpPDZqH9M7iZ4XdFnc5alDLSl+aQ+xTx5A=; 3:CLja8TVgE/A/dp5mnjgdw7oMiqZh3n8q8BxEg9ypAxPFMxF395iSPgOfzmNE9R5jWFaoTEcnXzGMiTx3gxZ/z6efSNlgHmWqMpT+p37KufmV9t1yxbdX2Y5TDaCoizlp/+yo1weSSGNvOwjx4pfhNvPAyKwyMfKztAvVugPtxHf10318jz62skgLWa9bIp5ODnfDYaEr8Eh/IrGOLHZvMVDMmzHoor+V+4r4ouXMjpo=; 25:SDNTOXrtgCmr9YMiINK+JLWIv4spCFOAV3JkRs/medGwt7hwP6WKQ6c3nfW8bFU7zCx/c2itObU4mvo9zmrAwssxkMxegjIiU9ukq2TzmG7YPR9cHuFXc15FKVmFEazyC6GH/seb7EZr+TQd1wSusp53YJOGn9nblOWh3SUuw5Jc2H38SYnBiLavo8QCrCMvOXGGOO4S2x9MqGkxpFXAbMgi2HtusuFoKqtr/a5Azg9pdWOppegfpEo6D3F+hPSvQ8gHG/dWTF2uhRkckp9lZQ==; 20:BBR+D6nZ8051bISkfiQxV6wMXGFG9QydI/MEwZYAqDcncXYsleJxOPScFhGY7N5fmbdlPiEOZFtUZV65YyecmG9f1r6QggqDXivb5tiUYnEYMtFo02WBWGGbFP3nElSb885iJGvFAQ/91dWO/E797KOdGZmpnTVxPSWhPSeWwng= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR02MB1152; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(8121501046)(5005006)(3002001); SRVR:VI1PR02MB1152; BCL:0; PCL:0; RULEID:; SRVR:VI1PR02MB1152; X-Microsoft-Exchange-Diagnostics: 1; VI1PR02MB1152; 4:6ioVzDYgsNB5k+db/+jGfQMjKZa6rT4v2hC/4tF2dg4/SY9IZf16rUAJ7j5EBwNGtg4YRX1P9e58UozLrvSm2f7pBBJSuRN3UuNNL7hXtuHAVxM9xQYcXzPgzzvrufkWlWMWsUIYuOVnMRGfGq6V1ufCaDw1YLtKzADO1lw041OqrDz4/SHl69xUVneEvRpPvSaUYe3C/f38FGwmw2p5LiQd23EwZrlRPXPR7EEq8c7HYL6TyDVk493dWSgHsg6x7a/A7GHsiguyvfTMOoZvCkabXtgJZ+sICLcPVl0OrMa+3skugSGZx8wFUGVpqYlT X-Forefront-PRVS: 0671F32598 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR02MB1152; 23:FEMhd0uxMr6uLCj6maDvJkh19548DO0C8qQt6QKQZ?= =?us-ascii?Q?aw4yNQ1nx+um1i0QXObIq1LHN6GRgoeriBQ1E2d48CNByy0HzxdSC6YqPy+6?= =?us-ascii?Q?Q+Z5Ao5FRi7K/+fKrIKbgRCl5QKA1GH57VUl+5i5bdQB8U2IPwyGI4PHAjZr?= =?us-ascii?Q?R9CM+TECyKciTzbiMg8uV3pj+sYD0VipTEFF2PSgP3udVnxNhCFzOq114dsL?= =?us-ascii?Q?lVGwHt+aumU8yz8Fbh8tjfzs8055OEi1UdNPZOF68vkDck3IlRusr+l8Jp8R?= =?us-ascii?Q?gJcxEoaSOGThRsO2gR018Xv3SyNyraUM14hW6qjSHetOvNCTIx+gP3xV9usX?= =?us-ascii?Q?MVWJQdVrc2152p8e8TGbhpiLcRinlvpHk+HWj4wZEAFlK+nwxmh4pXeJi6+z?= =?us-ascii?Q?vk6G2m701TtGjfaGLsaJ2lue+eg23rF0w++SfohTO+C4YysataxJvuRfQdHg?= =?us-ascii?Q?/eiLf8SeiRXNZIy7GC6iB87xPv89WdRF3hI/9py0LYp9Q3otgPIMA0Ck0UhE?= =?us-ascii?Q?m5WJFQEiXjyTtnC1x16pdCcJdBNdmfJGISLOnNty4X7tKHEMbn5MzkoN7+I9?= =?us-ascii?Q?t0zn8oTG46Jma4tDtP+G4foSIfKsr3gP8nUSjbdhuQt913KYdyvROQADxsrl?= =?us-ascii?Q?jAcXQvTEWbN0+N0Sybd8YKyYbKM2lVwBkViAnpEkuMiWIjR6N5wilc74F7jX?= =?us-ascii?Q?yhXX1wy8Z2brmOgeGnFc6BImAapKOrjNtqcnZ8Zr/YrmW1aNJRnUBohZRxNI?= =?us-ascii?Q?2wNkpo6+jI6dmwQ+ackyAteQkSxlaKN8J3uiPR6i8NfusydoamYPR+OvHhWk?= =?us-ascii?Q?jAV88RMul4yUj6zyuDOdervkntuggZd9+BYCI5oc1jLGaVZOfYQuZerX2fFG?= =?us-ascii?Q?vxsYLBiaTpVjrfRpd6ihI4M4IvuyO9ObiE+9eP38LvLhhrnY6Moq/cq9biNo?= =?us-ascii?Q?j4ws9NWhDtAx9EKqb/KcpoKsHUHDpYc6pffIjGFu/8KzDRjSYSq/lfOVFs4L?= =?us-ascii?Q?ykI0MA395J/Z91SX4N9+vQpb//E6aOJSuoVaRMCiEnIOYUTAT3l763ArAsEs?= =?us-ascii?Q?ROYCNWGgKuxUYDr73ckADonGpcrB1w32La9BqJzmzPhyak80TTBB221yqIgn?= =?us-ascii?Q?tUWp0gq29G8QdoLpJqC5vl2VT3uyfw6kfeqBDNzJb9w4Rbp13yVhA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; VI1PR02MB1152; 5:xT7cU7LAaos8D4HZAEBgttZ+2fhwalFVNFEzN/BLCY5Ks4SI30JHzVSq9L9jYeoWyXtA6Hb0CblVJ1dZLlR2PFwTg9HfyJwztuqdM1+XPxPTdoXKVEGs2cnmcL5Gk/VZfTe0bKTWcFh0n5cjtfG9lA==; 24:atigsGODNrwsIZ++ujaZ5RwvBBMs6ncdpcvgaf/wowVIJLQkZDJZOLAeOoJ81czcmGMEoBmZ0csSeeBRgt0GwBf0MR8IyGcxb5R5Yc/j0DA=; 20:v84/8gjuWCgulCGCyxWj6QqaS2g+FZoYgVucAa+0PWRqXCSafNU266RKg2bZCvAHJhVfNHXv8DnY9EW8KaF9hQ== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2015 06:02:14.7222 (UTC) X-MS-Exchange-CrossTenant-Id: 0fc16e0a-3cd3-4092-8b2f-0a42cff122c3 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=0fc16e0a-3cd3-4092-8b2f-0a42cff122c3; Ip=[212.179.42.66]; Helo=[ezex10.ezchip.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR02MB1152 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Noam Camus We define buf_int_enable in the minimal namespace it is used. Signed-off-by: Noam Camus --- drivers/net/ethernet/ezchip/nps_enet.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/ezchip/nps_enet.c b/drivers/net/ethernet/ezchip/nps_enet.c index de4aafd..3ba9be4 100644 --- a/drivers/net/ethernet/ezchip/nps_enet.c +++ b/drivers/net/ethernet/ezchip/nps_enet.c @@ -179,14 +179,15 @@ static int nps_enet_poll(struct napi_struct *napi, int budget) { struct net_device *ndev = napi->dev; struct nps_enet_priv *priv = netdev_priv(ndev); - struct nps_enet_buf_int_enable buf_int_enable; u32 work_done; - buf_int_enable.rx_rdy = NPS_ENET_ENABLE; - buf_int_enable.tx_done = NPS_ENET_ENABLE; work_done = nps_enet_rx_handler(ndev); if (work_done < budget) { + struct nps_enet_buf_int_enable buf_int_enable; + napi_complete(napi); + buf_int_enable.rx_rdy = NPS_ENET_ENABLE; + buf_int_enable.tx_done = NPS_ENET_ENABLE; nps_enet_reg_set(priv, NPS_ENET_REG_BUF_INT_ENABLE, buf_int_enable.value); }