From patchwork Wed Aug 12 15:10:23 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 506679 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A8E251401AF for ; Thu, 13 Aug 2015 01:10:54 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=tayUpXoe; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933400AbbHLPKs (ORCPT ); Wed, 12 Aug 2015 11:10:48 -0400 Received: from mail-yk0-f171.google.com ([209.85.160.171]:35513 "EHLO mail-yk0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932147AbbHLPKs (ORCPT ); Wed, 12 Aug 2015 11:10:48 -0400 Received: by ykdz80 with SMTP id z80so16384901ykd.2 for ; Wed, 12 Aug 2015 08:10:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=7cym9DdrPVNHbqmN7YnLM7YmbZ5fNrT8Fff75qVzTcs=; b=tayUpXoeQP/DBM0PmYfETmRzNkSqa3+e+ejZ5uATLi8L34GHM99wLXAaBQgHVP6AIv DpXKVb//EwvzxN0WCGhlFFrPdnO0lp9B3zImKsRjXbbvUt8D4KVtfW8dFxOMtLXwO70N 3Omz9XGXBKQpu9eZYNMlgfjRLyIvbHtwqhNMvvG20hRx9KFvoE83aomOdVVmuqdFAFhR ie5/rdgVSQdWthBr2XIiI/tRe40dC8AAgtAVf/cMC9YaxmZuhFqxpvRNrYF82rkXpYUV 4eFwiLpKsasMW7nhJjyC9fb9BWZ7AYJuG/XRvxZLl8L6848kdu55QQfOEzV55ofagneu 6Apw== X-Received: by 10.13.211.67 with SMTP id v64mr33211993ywd.120.1439392247623; Wed, 12 Aug 2015 08:10:47 -0700 (PDT) Received: from localhost.localdomain ([187.64.233.140]) by smtp.gmail.com with ESMTPSA id z132sm4868943ywa.21.2015.08.12.08.10.45 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 12 Aug 2015 08:10:47 -0700 (PDT) From: Fabio Estevam To: davem@davemloft.net Cc: Julia.Lawall@lip6.fr, netdev@vger.kernel.org, Fabio Estevam Subject: [PATCH net-next] net: fec: Remove unneeded use of IS_ERR_VALUE() macro Date: Wed, 12 Aug 2015 12:10:23 -0300 Message-Id: <1439392223-28350-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Fabio Estevam There is no need to use the IS_ERR_VALUE() macro for checking the return value from pm_runtime_* functions. Just do a simple negative test instead. The semantic patch that makes this change is available in scripts/coccinelle/api/pm_runtime.cocci. Signed-off-by: Fabio Estevam --- drivers/net/ethernet/freescale/fec_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 3cebf93..787da8e 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -1779,7 +1779,7 @@ static int fec_enet_mdio_read(struct mii_bus *bus, int mii_id, int regnum) int ret = 0; ret = pm_runtime_get_sync(dev); - if (IS_ERR_VALUE(ret)) + if (ret < 0) return ret; fep->mii_timeout = 0; @@ -1818,7 +1818,7 @@ static int fec_enet_mdio_write(struct mii_bus *bus, int mii_id, int regnum, int ret = 0; ret = pm_runtime_get_sync(dev); - if (IS_ERR_VALUE(ret)) + if (ret < 0) return ret; fep->mii_timeout = 0; @@ -2870,7 +2870,7 @@ fec_enet_open(struct net_device *ndev) int ret; ret = pm_runtime_get_sync(&fep->pdev->dev); - if (IS_ERR_VALUE(ret)) + if (ret < 0) return ret; pinctrl_pm_select_default_state(&fep->pdev->dev);