From patchwork Wed Aug 12 00:41:56 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Jakub_Kici=C5=84ski?= X-Patchwork-Id: 506274 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 104FB1401AF for ; Wed, 12 Aug 2015 10:42:11 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=wp.pl header.i=@wp.pl header.b=jT0hWhyg; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933297AbbHLAmH (ORCPT ); Tue, 11 Aug 2015 20:42:07 -0400 Received: from mx4.wp.pl ([212.77.101.12]:43568 "EHLO mx4.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933045AbbHLAmF (ORCPT ); Tue, 11 Aug 2015 20:42:05 -0400 Received: (wp-smtpd smtp.wp.pl 6252 invoked from network); 12 Aug 2015 02:42:02 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1439340123; bh=qPqmAUUszYXE0Jn8S1tv/rdw3s2mzKlYnc8lFm1/XEY=; h=From:To:Cc:Subject; b=jT0hWhygX9b09Gpw90d/9lb651cDTE4+4vnzepQvoyboG0h5jEIpNYTCVmJQ3OUwN k5unCdq4GGcEzSyNKIn3LWwf81/p8aX+JsOP+rSJPza7eBwgPVr+l7fq4CCqGIsbTE pYjdPGK5hl9UT/L3caBxVoW0tpNwdCkwU3yT/9mA= Received: from 89-69-164-220.dynamic.chello.pl (HELO north.moorray.no-ip.org) (moorray3@[89.69.164.220]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 12 Aug 2015 02:42:02 +0200 Received: by north.moorray.no-ip.org (sSMTP sendmail emulation); Wed, 12 Aug 2015 02:42:02 +0200 From: Jakub Kicinski To: "David S. Miller" , Claudiu Manoil Cc: netdev@vger.kernel.org, Jakub Kicinski Subject: [PATCHv2 2/3] gianfar: correct list membership accounting Date: Wed, 12 Aug 2015 02:41:56 +0200 Message-Id: <1439340117-25314-3-git-send-email-moorray3@wp.pl> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1439340117-25314-1-git-send-email-moorray3@wp.pl> References: <1439237540-11302-1-git-send-email-moorray3@wp.pl> <1439340117-25314-1-git-send-email-moorray3@wp.pl> X-WP-DKIM-Status: good (id: wp.pl) X-WP-MailID: ea8830e5d65d094cf2b3463022de2f5e X-WP-AV: skaner antywirusowy poczty Wirtualnej Polski S. A. X-WP-SPAM: NO 0000000 [4YN0] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jakub Kicinski At a cost of one line let's make sure .count is correct when calling gfar_process_filer_changes(). Signed-off-by: Jakub Kicinski --- v2: no change --- drivers/net/ethernet/freescale/gianfar_ethtool.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c index e543d3b01838..b955ed83ca98 100644 --- a/drivers/net/ethernet/freescale/gianfar_ethtool.c +++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c @@ -1723,13 +1723,14 @@ static int gfar_add_cls(struct gfar_private *priv, } process: + priv->rx_list.count++; ret = gfar_process_filer_changes(priv); if (ret) goto clean_list; - priv->rx_list.count++; return ret; clean_list: + priv->rx_list.count--; list_del(&temp->list); clean_mem: kfree(temp);