From patchwork Mon Aug 10 20:12:19 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Jakub_Kici=C5=84ski?= X-Patchwork-Id: 505780 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id F1E77140326 for ; Tue, 11 Aug 2015 06:12:35 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=wp.pl header.i=@wp.pl header.b=PFBeKE9H; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932730AbbHJUMc (ORCPT ); Mon, 10 Aug 2015 16:12:32 -0400 Received: from mx3.wp.pl ([212.77.101.9]:7026 "EHLO mx3.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752498AbbHJUMa (ORCPT ); Mon, 10 Aug 2015 16:12:30 -0400 Received: (wp-smtpd smtp.wp.pl 6686 invoked from network); 10 Aug 2015 22:12:27 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1439237548; bh=XFJUZR2TkvEIODnM2UZCwmkQVqtmNmr2iVJGH5w+TpI=; h=From:To:Cc:Subject; b=PFBeKE9HmMxJP9yPrfAUd1t0C8Z4dxKb4YpLProFG2+aXC7yS4b5ZgeGnUczy1aXJ ri+XaxrBguml2aG+RWVEiw0F3xWj0S0RiyIMMuehx1+LD9ISwyRuYWoYUyHvZz6KR9 Dr/HiEJqCBniapTT7Ss/4ttKgfVAOGv88QrbREKQ= Received: from 89-69-164-220.dynamic.chello.pl (HELO north.moorray.no-ip.org) (moorray3@[89.69.164.220]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 10 Aug 2015 22:12:27 +0200 Received: by north.moorray.no-ip.org (sSMTP sendmail emulation); Mon, 10 Aug 2015 22:12:27 +0200 From: Jakub Kicinski To: "David S. Miller" , Claudiu Manoil Cc: netdev@vger.kernel.org, Jakub Kicinski Subject: [PATCH 2/3] gianfar: correct list membership accounting Date: Mon, 10 Aug 2015 22:12:19 +0200 Message-Id: <1439237540-11302-3-git-send-email-moorray3@wp.pl> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1439237540-11302-1-git-send-email-moorray3@wp.pl> References: <1439237540-11302-1-git-send-email-moorray3@wp.pl> X-WP-DKIM-Status: good (id: wp.pl) X-WP-MailID: 3b5752a57f0d67afe62930a9afd8c5c5 X-WP-AV: skaner antywirusowy poczty Wirtualnej Polski S. A. X-WP-SPAM: NO 0000000 [IWN0] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jakub Kicinski At a cost of one line let's make sure .count is correct when calling gfar_process_filer_changes(). Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/freescale/gianfar_ethtool.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c index e543d3b01838..b955ed83ca98 100644 --- a/drivers/net/ethernet/freescale/gianfar_ethtool.c +++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c @@ -1723,13 +1723,14 @@ static int gfar_add_cls(struct gfar_private *priv, } process: + priv->rx_list.count++; ret = gfar_process_filer_changes(priv); if (ret) goto clean_list; - priv->rx_list.count++; return ret; clean_list: + priv->rx_list.count--; list_del(&temp->list); clean_mem: kfree(temp);