| Message ID | 1437541022-14250-1-git-send-email-rami.rosen@intel.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On 7/21/15, 9:57 PM, Rami Rosen wrote: > This patch fixes setting of vinfo.flags in the br_fill_ifvlaninfo_range() method. The > assignment of vinfo.flags &= ~BRIDGE_VLAN_INFO_RANGE_BEGIN has no effect and is > unneeded, as vinfo.flags value is overriden by the immediately following > vinfo.flags = flags | BRIDGE_VLAN_INFO_RANGE_END assignement. > > Signed-off-by: Rami Rosen <rami.rosen@intel.com> > Acked-by: Roopa Prabhu <roopa@cumulusnetworks.com> Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Rami Rosen <rami.rosen@intel.com> Date: Wed, 22 Jul 2015 07:57:02 +0300 > This patch fixes setting of vinfo.flags in the br_fill_ifvlaninfo_range() method. The > assignment of vinfo.flags &= ~BRIDGE_VLAN_INFO_RANGE_BEGIN has no effect and is > unneeded, as vinfo.flags value is overriden by the immediately following > vinfo.flags = flags | BRIDGE_VLAN_INFO_RANGE_END assignement. > > Signed-off-by: Rami Rosen <rami.rosen@intel.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c index 364bdc9..793d247 100644 --- a/net/bridge/br_netlink.c +++ b/net/bridge/br_netlink.c @@ -164,8 +164,6 @@ static int br_fill_ifvlaninfo_range(struct sk_buff *skb, u16 vid_start, sizeof(vinfo), &vinfo)) goto nla_put_failure; - vinfo.flags &= ~BRIDGE_VLAN_INFO_RANGE_BEGIN; - vinfo.vid = vid_end; vinfo.flags = flags | BRIDGE_VLAN_INFO_RANGE_END; if (nla_put(skb, IFLA_BRIDGE_VLAN_INFO,
This patch fixes setting of vinfo.flags in the br_fill_ifvlaninfo_range() method. The assignment of vinfo.flags &= ~BRIDGE_VLAN_INFO_RANGE_BEGIN has no effect and is unneeded, as vinfo.flags value is overriden by the immediately following vinfo.flags = flags | BRIDGE_VLAN_INFO_RANGE_END assignement. Signed-off-by: Rami Rosen <rami.rosen@intel.com> --- net/bridge/br_netlink.c | 2 -- 1 file changed, 2 deletions(-)