From patchwork Wed Jul 8 21:00:56 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xi Wang X-Patchwork-Id: 493154 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 8F2461402C9 for ; Thu, 9 Jul 2015 07:01:37 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=qC9q7ISW; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932146AbbGHVBd (ORCPT ); Wed, 8 Jul 2015 17:01:33 -0400 Received: from mail-pd0-f175.google.com ([209.85.192.175]:36324 "EHLO mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755208AbbGHVBc (ORCPT ); Wed, 8 Jul 2015 17:01:32 -0400 Received: by pddu5 with SMTP id u5so64428764pdd.3 for ; Wed, 08 Jul 2015 14:01:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=Mo+MAZ5r7Sxy3eMmKjJvBfiOykMvnaZuFj59vRQQhhE=; b=qC9q7ISW0V5T6m/AXGOpWsa2ESXoconNigD84CrwbXonSvw0TkIylf3OjeAC+Kjnax isgTLBhvVn52q96muKtoP4H9xijqHOdHL7gdcFU7mfLKIo4ITrY4grRCAF48tY+2yu3P hqRfWCx2RF1N98/PsBqdQxNgQIqJ1mWDSI6ERxJr3sDYkcjQhvW4g2z8dTIapMjrYF5Y Cn4s4/jstZbGqQA3eDtX5S5Ip1pLU90FGfxIWMeNy2LpH3fxZ0W6UEWqtwmTsL+Qt8Aj kAOSNg1n5L4Kib8NaGRIIJZsbGLiS/14TKz9J40n31k3IG+E95tAJmrIYeNDheX7knsG I5kg== X-Received: by 10.68.245.42 with SMTP id xl10mr23955684pbc.153.1436389291734; Wed, 08 Jul 2015 14:01:31 -0700 (PDT) Received: from sysv.cs.washington.edu (sysv.cs.washington.edu. [128.208.2.74]) by smtp.gmail.com with ESMTPSA id ht9sm3504662pdb.0.2015.07.08.14.01.30 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 08 Jul 2015 14:01:31 -0700 (PDT) From: Xi Wang To: netdev@vger.kernel.org Cc: Xi Wang Subject: [PATCH net-next RESEND] test_bpf: extend tests for 32-bit endianness conversion Date: Wed, 8 Jul 2015 14:00:56 -0700 Message-Id: <1436389256-28483-1-git-send-email-xi.wang@gmail.com> X-Mailer: git-send-email 2.1.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Currently "ALU_END_FROM_BE 32" and "ALU_END_FROM_LE 32" do not test if the upper bits of the result are zeros (the arm64 JIT had such bugs). Extend the two tests to catch this. Acked-by: Daniel Borkmann Acked-by: Alexei Starovoitov Signed-off-by: Xi Wang --- See the arm64 JIT bugs: https://lkml.org/lkml/2015/6/25/721 --- lib/test_bpf.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/test_bpf.c b/lib/test_bpf.c index 7f58c73..9198f28 100644 --- a/lib/test_bpf.c +++ b/lib/test_bpf.c @@ -3674,6 +3674,9 @@ static struct bpf_test tests[] = { .u.insns_int = { BPF_LD_IMM64(R0, 0x0123456789abcdefLL), BPF_ENDIAN(BPF_FROM_BE, R0, 32), + BPF_ALU64_REG(BPF_MOV, R1, R0), + BPF_ALU64_IMM(BPF_RSH, R1, 32), + BPF_ALU32_REG(BPF_ADD, R0, R1), /* R1 = 0 */ BPF_EXIT_INSN(), }, INTERNAL, @@ -3708,6 +3711,9 @@ static struct bpf_test tests[] = { .u.insns_int = { BPF_LD_IMM64(R0, 0x0123456789abcdefLL), BPF_ENDIAN(BPF_FROM_LE, R0, 32), + BPF_ALU64_REG(BPF_MOV, R1, R0), + BPF_ALU64_IMM(BPF_RSH, R1, 32), + BPF_ALU32_REG(BPF_ADD, R0, R1), /* R1 = 0 */ BPF_EXIT_INSN(), }, INTERNAL,