From patchwork Fri Jun 26 15:25:20 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xi Wang X-Patchwork-Id: 488909 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id EAF61140271 for ; Sat, 27 Jun 2015 01:25:55 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=xXEGStxb; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753243AbbFZPZd (ORCPT ); Fri, 26 Jun 2015 11:25:33 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:33999 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751931AbbFZPZa (ORCPT ); Fri, 26 Jun 2015 11:25:30 -0400 Received: by pabvl15 with SMTP id vl15so70555885pab.1; Fri, 26 Jun 2015 08:25:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=E+vLZX/JuP02YdF+3ThWwrWo6TmcqDrdTbOEnUWXgTg=; b=xXEGStxbKIUrFAfDHSYBkAUaA+yTLUnuecCKNH/urbhA+o9CehkA9x4xtZh5Deb9PR XJm+jU/mjQ08vRs2n+CSNRDCP8ycVTNkg7McrbTUIOEr0vi7r6mnHXmkL/PEkcaUkLoD B5nDUZQ+YIi8kfPi5TH90b1U3jE25To6UQXhCUs0MSUeu8Uzm0+hORgZaLR1OR9FqYsu G33aLstZVzaTh5Xq6hKZ/X+IVf1HlWpxgrNWJCcliwnytuGvppHridCMWtsZnXhvYuUv wgiNGNycxm2lCFFs3pFBTht026vG/fOY14maFZ/mIZXGBkPjIMzpvLAqUmf4bngP0pwY JlGg== X-Received: by 10.70.22.131 with SMTP id d3mr4432225pdf.67.1435332329456; Fri, 26 Jun 2015 08:25:29 -0700 (PDT) Received: from sysv.cs.washington.edu (sysv.cs.washington.edu. [128.208.2.74]) by mx.google.com with ESMTPSA id ff10sm33811083pab.13.2015.06.26.08.25.28 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 26 Jun 2015 08:25:28 -0700 (PDT) From: Xi Wang To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Xi Wang , Alexei Starovoitov Subject: [PATCH net-next] test_bpf: extend tests for 32-bit endianness conversion Date: Fri, 26 Jun 2015 08:25:20 -0700 Message-Id: <1435332320-6476-1-git-send-email-xi.wang@gmail.com> X-Mailer: git-send-email 2.1.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Currently "ALU_END_FROM_BE 32" and "ALU_END_FROM_LE 32" do not test if the upper bits of the result are zeros (the arm64 JIT had such bugs). Extend the two tests to catch this. Cc: Alexei Starovoitov Signed-off-by: Xi Wang Acked-by: Daniel Borkmann --- See the arm64 JIT bugs: https://lkml.org/lkml/2015/6/25/721 --- lib/test_bpf.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/test_bpf.c b/lib/test_bpf.c index 7f58c73..9198f28 100644 --- a/lib/test_bpf.c +++ b/lib/test_bpf.c @@ -3674,6 +3674,9 @@ static struct bpf_test tests[] = { .u.insns_int = { BPF_LD_IMM64(R0, 0x0123456789abcdefLL), BPF_ENDIAN(BPF_FROM_BE, R0, 32), + BPF_ALU64_REG(BPF_MOV, R1, R0), + BPF_ALU64_IMM(BPF_RSH, R1, 32), + BPF_ALU32_REG(BPF_ADD, R0, R1), /* R1 = 0 */ BPF_EXIT_INSN(), }, INTERNAL, @@ -3708,6 +3711,9 @@ static struct bpf_test tests[] = { .u.insns_int = { BPF_LD_IMM64(R0, 0x0123456789abcdefLL), BPF_ENDIAN(BPF_FROM_LE, R0, 32), + BPF_ALU64_REG(BPF_MOV, R1, R0), + BPF_ALU64_IMM(BPF_RSH, R1, 32), + BPF_ALU32_REG(BPF_ADD, R0, R1), /* R1 = 0 */ BPF_EXIT_INSN(), }, INTERNAL,