| Message ID | 1432916524-20881-1-git-send-email-ian.campbell@citrix.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sun, 2015-05-31 at 21:26 -0700, David Miller wrote: > From: Ian Campbell <ian.campbell@citrix.com> > Date: Fri, 29 May 2015 17:22:04 +0100 > > > drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_build_gops’: > > drivers/net/xen-netback/netback.c:1253:8: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘int’ [-Wformat=] > > (txreq.offset&~PAGE_MASK) + txreq.size); > > ^ > > > > txreq.offset and .size are uint16_t fields. > > > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com> > > This may get rid of the compiler warning on your machine, but it creates > one on mine: > > drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_build_gops’: > drivers/net/xen-netback/netback.c:1253:8: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 5 has type ‘long unsigned int’ [-Wformat=] > (txreq.offset&~PAGE_MASK) + txreq.size); > ^ > > There is a type involved in this calculation which is arch > dependent, so you'll need to add a cast or something to > make this warning go away in all cases. Ah, I only considered the types txreq.{offset,size} and missed thinking about PAGE_MASK. I'll resend with a cast. Ian. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 4de46aa..a3b1cbb 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -1248,7 +1248,7 @@ static void xenvif_tx_build_gops(struct xenvif_queue *queue, /* No crossing a page as the payload mustn't fragment. */ if (unlikely((txreq.offset + txreq.size) > PAGE_SIZE)) { netdev_err(queue->vif->dev, - "txreq.offset: %x, size: %u, end: %lu\n", + "txreq.offset: %x, size: %u, end: %u\n", txreq.offset, txreq.size, (txreq.offset&~PAGE_MASK) + txreq.size); xenvif_fatal_tx_err(queue->vif);
drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_build_gops’: drivers/net/xen-netback/netback.c:1253:8: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘int’ [-Wformat=] (txreq.offset&~PAGE_MASK) + txreq.size); ^ txreq.offset and .size are uint16_t fields. Signed-off-by: Ian Campbell <ian.campbell@citrix.com> --- drivers/net/xen-netback/netback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)