Message ID | 1432723472-7793-1-git-send-email-ross.lagerwall@citrix.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
On Wed, May 27, 2015 at 11:44:32AM +0100, Ross Lagerwall wrote: > Commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into queue > struct") introduced a regression when moving queue-specific data into > the queue struct by failing to set the credit_bytes field. This > prevented bandwidth limiting from working. Initialize the field as it > was done before multiqueue support was added. > > Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com> Acked-by: Wei Liu <wei.liu2@citrix.com> > --- > > Changed in v2: Fixed multiple-assignment. > > drivers/net/xen-netback/xenbus.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c > index 3d8dbf5..fee0241 100644 > --- a/drivers/net/xen-netback/xenbus.c > +++ b/drivers/net/xen-netback/xenbus.c > @@ -793,6 +793,7 @@ static void connect(struct backend_info *be) > goto err; > } > > + queue->credit_bytes = credit_bytes; > queue->remaining_credit = credit_bytes; > queue->credit_usec = credit_usec; > > -- > 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Ross Lagerwall <ross.lagerwall@citrix.com> Date: Wed, 27 May 2015 11:44:32 +0100 > Commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into queue > struct") introduced a regression when moving queue-specific data into > the queue struct by failing to set the credit_bytes field. This > prevented bandwidth limiting from working. Initialize the field as it > was done before multiqueue support was added. > > Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com> Applied, thanks Ross. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index 3d8dbf5..fee0241 100644 --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -793,6 +793,7 @@ static void connect(struct backend_info *be) goto err; } + queue->credit_bytes = credit_bytes; queue->remaining_credit = credit_bytes; queue->credit_usec = credit_usec;
Commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into queue struct") introduced a regression when moving queue-specific data into the queue struct by failing to set the credit_bytes field. This prevented bandwidth limiting from working. Initialize the field as it was done before multiqueue support was added. Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com> --- Changed in v2: Fixed multiple-assignment. drivers/net/xen-netback/xenbus.c | 1 + 1 file changed, 1 insertion(+)