From patchwork Thu May 14 16:06:23 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tejun Heo X-Patchwork-Id: 472387 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A08641402B2 for ; Fri, 15 May 2015 02:07:45 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=Q9XmyIEz; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422694AbbENQGu (ORCPT ); Thu, 14 May 2015 12:06:50 -0400 Received: from mail-qc0-f176.google.com ([209.85.216.176]:33988 "EHLO mail-qc0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422676AbbENQGr (ORCPT ); Thu, 14 May 2015 12:06:47 -0400 Received: by qcyk17 with SMTP id k17so42163704qcy.1; Thu, 14 May 2015 09:06:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=a230RQtkcSF23L4Ly0sxexLcpVUn6uJS0DBYH7Wai7k=; b=Q9XmyIEzCbz3G7tYrREIwQBVzGxaa/kgtiibB9EFOOqfZrLpldS/iK6/YIk2pZ12r3 Zw172bN89WTx/qTLDi9PARRJg+xy9HWplcz+ZSirW6g+c4YyzGeEIjC45uGN5PWIEcaf nTdaYK2aEHmmAbId/gd4mUTpFPT4LNU8Xjbm9Xl741iqdBzuvx51OjP08t6691tyQ9Kp xsm4MSK2fQfnFKDQ0WIMqp63L/FnqgCHKxCkcCOFZ8kWMeuPKzS8dB4C3Tr9CjDKPZt7 RFKhldxl2b72y0raRckDsXdVV/ghWqj3UTrQ3XTxbV5DVGpLzYpJoealywWhzAPxDAzW 5PJg== X-Received: by 10.140.89.200 with SMTP id v66mr6289289qgd.50.1431619606179; Thu, 14 May 2015 09:06:46 -0700 (PDT) Received: from htj.duckdns.org.lan (207-38-238-8.c3-0.wsd-ubr1.qens-wsd.ny.cable.rcn.com. [207.38.238.8]) by mx.google.com with ESMTPSA id y195sm18099132qky.24.2015.05.14.09.06.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 May 2015 09:06:45 -0700 (PDT) From: Tejun Heo To: akpm@linux-foundation.org Cc: davem@davemloft.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Tejun Heo Subject: [PATCH 4/7] netconsole: remove unnecessary netconsole_target_get/out() from write_msg() Date: Thu, 14 May 2015 12:06:23 -0400 Message-Id: <1431619586-29187-5-git-send-email-tj@kernel.org> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1431619586-29187-1-git-send-email-tj@kernel.org> References: <1431619586-29187-1-git-send-email-tj@kernel.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org write_msg() grabs target_list_lock and walks target_list invoking netpool_send_udp() on each target. Curiously, it protects each iteration with netconsole_target_get/put() even though it never releases target_list_lock which protects all the members. While this doesn't harm anything, it doesn't serve any purpose either. The items on the list can't go away while target_list_lock is held. Remove the unnecessary get/put pair. Signed-off-by: Tejun Heo Cc: David Miller --- drivers/net/netconsole.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index 15731d1..30c0524 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -744,7 +744,6 @@ static void write_msg(struct console *con, const char *msg, unsigned int len) spin_lock_irqsave(&target_list_lock, flags); list_for_each_entry(nt, &target_list, list) { - netconsole_target_get(nt); if (nt->enabled && netif_running(nt->np.dev)) { /* * We nest this inside the for-each-target loop above @@ -760,7 +759,6 @@ static void write_msg(struct console *con, const char *msg, unsigned int len) left -= frag; } } - netconsole_target_put(nt); } spin_unlock_irqrestore(&target_list_lock, flags); }