From patchwork Sat May 9 08:14:30 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xi Wang X-Patchwork-Id: 470301 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id ACCA5140297 for ; Sat, 9 May 2015 18:15:14 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=L4j/3yDC; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752814AbbEIIOs (ORCPT ); Sat, 9 May 2015 04:14:48 -0400 Received: from mail-ig0-f182.google.com ([209.85.213.182]:35254 "EHLO mail-ig0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751307AbbEIIOl (ORCPT ); Sat, 9 May 2015 04:14:41 -0400 Received: by igbyr2 with SMTP id yr2so38215777igb.0; Sat, 09 May 2015 01:14:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=f/43WIaoI76Z5jR1uiQRu3GCNCojVL6gY2XTBkR7LsU=; b=L4j/3yDCzR17y1JSIJPDKVhESwYWr5LzVmXVzZ5/Gb2brGXMvIWxBPFtPHmHlmDWb9 sux63ahkizXIkvdYjA8MVPsc/MDf3s7p5DdPgPgS0weBFWvC9MCOnxo1k6d4byReQ8KT ghbnr/vpayNscG/ZUOToy2N2lJ0h6B3/YCEkf5nbCIio0MO4AQsU2KMhBZgWUsoMCMIh TRswaBRo/ZQPORb4l89Nl8ijcwp8XZqNwgzoN1vnJ8bAuLuFnqdHazyltdjy+cnwITDa GJydi/2RF+kbf3+8HjTVyUdIrMTEmNxMaZTc6/jwfMIo/rXIg0nDsdVg5OkJcr43MMXp BSww== X-Received: by 10.42.67.80 with SMTP id s16mr1875428ici.25.1431159281006; Sat, 09 May 2015 01:14:41 -0700 (PDT) Received: from hchen.csail.mit.edu (hchen.csail.mit.edu. [18.26.5.5]) by mx.google.com with ESMTPSA id 35sm5325327ior.34.2015.05.09.01.14.40 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 09 May 2015 01:14:40 -0700 (PDT) From: Xi Wang To: netdev@vger.kernel.org Cc: "David S. Miller" , linux-kernel@vger.kernel.org, Xi Wang , Alexei Starovoitov , Will Deacon Subject: [PATCH net-next] test: bpf: extend "load 64-bit immediate" testcase Date: Sat, 9 May 2015 04:14:30 -0400 Message-Id: <1431159270-2960-1-git-send-email-xi.wang@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Extend the testcase to catch a signedness bug in the arm64 JIT: test_bpf: #58 load 64-bit immediate jited:1 ret -1 != 1 FAIL (1 times) This is useful to ensure other JITs won't have a similar bug. Link: https://lkml.org/lkml/2015/5/8/458 Cc: Alexei Starovoitov Cc: Will Deacon Signed-off-by: Xi Wang Acked-by: Alexei Starovoitov Acked-by: Daniel Borkmann --- lib/test_bpf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/test_bpf.c b/lib/test_bpf.c index f2c23ffaa6d7..3c41049d72d8 100644 --- a/lib/test_bpf.c +++ b/lib/test_bpf.c @@ -1755,7 +1755,8 @@ static struct bpf_test tests[] = { BPF_EXIT_INSN(), BPF_JMP_IMM(BPF_JEQ, R3, 0x1234, 1), BPF_EXIT_INSN(), - BPF_ALU64_IMM(BPF_MOV, R0, 1), + BPF_LD_IMM64(R0, 0x1ffffffffLL), + BPF_ALU64_IMM(BPF_RSH, R0, 32), /* R0 = 1 */ BPF_EXIT_INSN(), }, INTERNAL,