diff mbox series

[net,v2] mptcp: print new line in mptcp_seq_show() if mptcp isn't in use

Message ID 142e2fd9-58d9-bb13-fb75-951cccc2331e@163.com
State Superseded
Headers show
Series [net,v2] mptcp: print new line in mptcp_seq_show() if mptcp isn't in use | expand

Commit Message

Jianguo Wu Dec. 5, 2020, 7:56 a.m. UTC 
From: Jianguo Wu <wujianguo@chinatelecom.cn>

When do cat /proc/net/netstat, the output isn't append with a new line, it looks like this:
[root@localhost ~]# cat /proc/net/netstat
...
MPTcpExt: 0 0 0 0 0 0 0 0 0 0 0 0 0[root@localhost ~]#

This is because in mptcp_seq_show(), if mptcp isn't in use, net->mib.mptcp_statistics is NULL,
so it just puts all 0 after "MPTcpExt:", and return, forgot the '\n'.

After this patch:

[root@localhost ~]# cat /proc/net/netstat
...
MPTcpExt: 0 0 0 0 0 0 0 0 0 0 0 0 0
[root@localhost ~]#

Fixes: fc518953bc9c8d7d ("mptcp: add and use MIB counter infrastructure")
Signed-off-by: Jianguo Wu <wujianguo@chinatelecom.cn>
Acked-by: Florian Westphal <fw@strlen.de>
---
 net/mptcp/mib.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jakub Kicinski Dec. 8, 2020, 1:46 a.m. UTC | #1 
On Sat, 5 Dec 2020 15:56:33 +0800 Jianguo Wu wrote:
> From: Jianguo Wu <wujianguo@chinatelecom.cn>
> 
> When do cat /proc/net/netstat, the output isn't append with a new line, it looks like this:
> [root@localhost ~]# cat /proc/net/netstat
> ...
> MPTcpExt: 0 0 0 0 0 0 0 0 0 0 0 0 0[root@localhost ~]#
> 
> This is because in mptcp_seq_show(), if mptcp isn't in use, net->mib.mptcp_statistics is NULL,
> so it just puts all 0 after "MPTcpExt:", and return, forgot the '\n'.
> 
> After this patch:
> 
> [root@localhost ~]# cat /proc/net/netstat
> ...
> MPTcpExt: 0 0 0 0 0 0 0 0 0 0 0 0 0
> [root@localhost ~]#
> 
> Fixes: fc518953bc9c8d7d ("mptcp: add and use MIB counter infrastructure")
> Signed-off-by: Jianguo Wu <wujianguo@chinatelecom.cn>
> Acked-by: Florian Westphal <fw@strlen.de>

Applied, thanks!
diff mbox series

Patch

diff --git a/net/mptcp/mib.c b/net/mptcp/mib.c
index 84d1194..b921cbd 100644
--- a/net/mptcp/mib.c
+++ b/net/mptcp/mib.c
@@ -67,6 +67,7 @@  void mptcp_seq_show(struct seq_file *seq)
 		for (i = 0; mptcp_snmp_list[i].name; i++)
 			seq_puts(seq, " 0");

+		seq_putc(seq, '\n');
 		return;
 	}