From patchwork Fri Apr 10 20:50:40 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Gospodarek X-Patchwork-Id: 460224 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 5A9F31401AD for ; Sat, 11 Apr 2015 06:51:19 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="verification failed; unprotected key" header.d=cumulusnetworks.com header.i=@cumulusnetworks.com header.b=CYA01n0z; dkim-adsp=none (unprotected policy); dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756137AbbDJUvP (ORCPT ); Fri, 10 Apr 2015 16:51:15 -0400 Received: from mail-qk0-f170.google.com ([209.85.220.170]:32815 "EHLO mail-qk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753252AbbDJUvO (ORCPT ); Fri, 10 Apr 2015 16:51:14 -0400 Received: by qkx62 with SMTP id 62so45439744qkx.0 for ; Fri, 10 Apr 2015 13:51:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=from:to:cc:subject:date:message-id; bh=fvl9stENiRCFc5VdErHX20lbz2Fdl3TbebP3hHbFQO4=; b=CYA01n0zpEEe1detJm+I2R4uiOZLVaXV8lLxsTfTc3D/m8tYn3/vWTOFkLpc9AKXOj 8v/MKn6UM5F898lq1wfMrPJe4ihPk8XqDqtMiXrVWbnRquzP4S5op00NuRhZfC+Aq9Q5 vxFeTP8qabCnPfvkiUuj8xpEyMkaKqEV0UexQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=fvl9stENiRCFc5VdErHX20lbz2Fdl3TbebP3hHbFQO4=; b=aRxqbBF+8KXk52aKO5xL6xO90pZMQrfy1fjysGiY4YxThtZQeYFhx9+4GKgAzhH2Rz rpIHrD1Mk7oCFNcS8HdUVhJmkWJzUg+z4vjk+/TK6kUhYVzYX0vmpbEGmDDcqqKyP64l GPS053iGLtSkoml7nf0PXbFpcaQ42+0dAUh3xlWST+vwI9fr4iw86QIE748zv8Opclmb hPGz2ZaOxx9hsfHvOayN8lKuOuYfb1KKDnn2Q+ZQbyHM4tul4CtKs4rGnyWVqIyHNVAI JZy83t27PZ5nnhguo27tegVFu+XF9QEMEtWnvzHdsNLkWwEYWc282M8EQVJ8MACHB0+f rkqA== X-Gm-Message-State: ALoCoQkGEoMFrnJNJ6E4OMlojBZizgbQ5cERQlrAFz0zKin6oWAX1QRKCbTN6z5VKR2/6lxBgGzF X-Received: by 10.229.246.74 with SMTP id lx10mr4314331qcb.21.1428699073370; Fri, 10 Apr 2015 13:51:13 -0700 (PDT) Received: from fedora-devel.rdu.cumulusnetworks.com (42-10-255-199.rev.celito.net. [199.255.10.42]) by mx.google.com with ESMTPSA id 21sm2424556qks.47.2015.04.10.13.51.12 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Apr 2015 13:51:12 -0700 (PDT) From: Andy Gospodarek To: netdev@vger.kernel.org Cc: Andy Gospodarek , Jamal Hadi Salim , Jeff Kirsher , Jiri Pirko , "John W. Linville" , Roopa Prabhu , Scott Feldman , Stephen Hemminger Subject: [PATCH iproute2] [PATCH iproute2 v2] iproute2: unify naming for entries offloaded to hardware Date: Fri, 10 Apr 2015 16:50:40 -0400 Message-Id: <1428699040-2071-1-git-send-email-gospo@cumulusnetworks.com> X-Mailer: git-send-email 1.9.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The kernel now has the capability to offload FDB and FIB entries to hardware. It is important to let users know if table entries are also offloaded to hardware. Currently offloaded FDB entries are indicated by the existence of the flag 'external' on the entry as of the following commit: commit 28467b7f3facd6114b2fbe0c9fecf57adbd52e12 Author: Scott Feldman Date: Thu Dec 4 09:57:15 2014 +0100 bridge/fdb: add flag/indication for FDB entry synced from offload device When the patch to add support for indicating that FIB entries were also offloaded as posted to netdev by Scott Feldman it became clear that 'external' would not be an ideal name for routes. There could definitely be confusion about what this might mean since many routes are to external networks -- a collision/confusion that did not happen with FDB. Scott Feldman asked me to check with others and build concensus around a name. After speaking with several people about this I am proposing we refer to both FDB and FIB entries that are currently backed by hardware (based on the work done in rocker) with the flag 'offload' appended to the end ofthe entry. Some people liked the string 'external,' others liked 'hardware,' but the point is to communicate that these routes are available to something that will will offload the forwarding normally done by the kernel. Since the term 'offload' is used so frequently it seems appropriate to use the same language in ip/bridge output. The term 'offload' also seems to resonate with many of the people who have responded on Scott's original thread or to those who I reached out to directly and did respond to my query, so it seems we have reached consensus that it should be the term used going forward. v2: rebased against net-next branch Signed-off-by: Andy Gospodarek CC: Jamal Hadi Salim CC: Jeff Kirsher CC: Jiri Pirko CC: John W. Linville CC: Roopa Prabhu CC: Scott Feldman CC: Stephen Hemminger --- bridge/fdb.c | 2 +- ip/iproute.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bridge/fdb.c b/bridge/fdb.c index 3c33e22..e34933b 100644 --- a/bridge/fdb.c +++ b/bridge/fdb.c @@ -159,7 +159,7 @@ int print_fdb(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg) if (r->ndm_flags & NTF_ROUTER) fprintf(fp, "router "); if (r->ndm_flags & NTF_EXT_LEARNED) - fprintf(fp, "external "); + fprintf(fp, "offload "); fprintf(fp, "%s\n", state_n2a(r->ndm_state)); return 0; diff --git a/ip/iproute.c b/ip/iproute.c index 132a83a..e0a6159 100644 --- a/ip/iproute.c +++ b/ip/iproute.c @@ -448,7 +448,7 @@ int print_route(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg) if (r->rtm_flags & RTNH_F_PERVASIVE) fprintf(fp, "pervasive "); if (r->rtm_flags & RTNH_F_EXTERNAL) - fprintf(fp, "external "); + fprintf(fp, "offload "); if (r->rtm_flags & RTM_F_NOTIFY) fprintf(fp, "notify "); if (tb[RTA_MARK]) {