From patchwork Wed Apr 8 11:20:39 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 459203 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 47D471401AD for ; Wed, 8 Apr 2015 21:22:54 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="verification failed; unprotected key" header.d=gmail.com header.i=@gmail.com header.b=Mnihqdvc; dkim-adsp=none (unprotected policy); dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754101AbbDHLW3 (ORCPT ); Wed, 8 Apr 2015 07:22:29 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:35683 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754008AbbDHLWV (ORCPT ); Wed, 8 Apr 2015 07:22:21 -0400 Received: by pabtp1 with SMTP id tp1so6224664pab.2; Wed, 08 Apr 2015 04:22:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8aZS9lxv/NEtbl9kIRItPFRjUkPkqf8TVcGWc6ce8L4=; b=MnihqdvccwLzUTiCZelSg7Ds9Ft4+3nauTBV3diKZjSEpU50pIWUzClZLIyHyT5uOG IEKoSCoYOtNa8vZc4pNRLG+7EFogq4YVX+bJbSGsfFn2ho48y/GlmHRttrOrYWKr6AaU JUik+WupGRFaZnJWtw8O0rxK4ZMWSImRu2Onb52LlyfIVKzTDGQBx9ZqJSh+SPL3TUtl 6N9CKjxKTCk4zjVDUIBZPu5FLjiuR2pfDyE7Azl7Pr0pKWHIj3REdvETTbEd3y8i30Go adi/5d8+jOQIbC5YCjUMj+GJmAHHm/jlw7/KS6w5DlMxR+XXBFaPdzA0Gk1GN8AeZ0+4 EayQ== X-Received: by 10.70.53.3 with SMTP id x3mr45504459pdo.133.1428492141057; Wed, 08 Apr 2015 04:22:21 -0700 (PDT) Received: from localhost.localdomain ([122.169.147.27]) by mx.google.com with ESMTPSA id og11sm10973411pdb.91.2015.04.08.04.22.15 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 08 Apr 2015 04:22:20 -0700 (PDT) From: Sudip Mukherjee To: Arnd Bergmann , Greg Kroah-Hartman , Jean Delvare , Wolfram Sang , Rodolfo Giometti , "James E.J. Bottomley" , Mark Brown , Willy Tarreau , Jaroslav Kysela , Takashi Iwai Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, netdev@vger.kernel.org, linux-scsi@vger.kernel.org, linux-spi@vger.kernel.org, devel@driverdev.osuosl.org, alsa-devel@alsa-project.org, Sudip Mukherjee Subject: [PATCH 13/14] ppdev: return proper error values from attach Date: Wed, 8 Apr 2015 16:50:39 +0530 Message-Id: <1428492040-5581-14-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1428492040-5581-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1428492040-5581-1-git-send-email-sudipm.mukherjee@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org now that we are monitoring the return value from attach, make the required changes to return proper value from its attach function. Signed-off-by: Sudip Mukherjee --- drivers/char/ppdev.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/char/ppdev.c b/drivers/char/ppdev.c index ae0b42b..14374d7 100644 --- a/drivers/char/ppdev.c +++ b/drivers/char/ppdev.c @@ -748,10 +748,14 @@ static const struct file_operations pp_fops = { .release = pp_release, }; -static void pp_attach(struct parport *port) +static int pp_attach(struct parport *port) { - device_create(ppdev_class, port->dev, MKDEV(PP_MAJOR, port->number), - NULL, "parport%d", port->number); + struct device *dev; + + dev = device_create(ppdev_class, port->dev, + MKDEV(PP_MAJOR, port->number), NULL, + "parport%d", port->number); + return PTR_ERR_OR_ZERO(dev); } static void pp_detach(struct parport *port)