From patchwork Wed Mar 25 00:33:05 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Gospodarek X-Patchwork-Id: 454112 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4048814012C for ; Wed, 25 Mar 2015 11:33:25 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="verification failed; unprotected key" header.d=cumulusnetworks.com header.i=@cumulusnetworks.com header.b=RF+ISltW; dkim-adsp=none (unprotected policy); dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752594AbbCYAdV (ORCPT ); Tue, 24 Mar 2015 20:33:21 -0400 Received: from mail-yk0-f173.google.com ([209.85.160.173]:34546 "EHLO mail-yk0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751915AbbCYAdT (ORCPT ); Tue, 24 Mar 2015 20:33:19 -0400 Received: by ykfc206 with SMTP id c206so5329597ykf.1 for ; Tue, 24 Mar 2015 17:33:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=from:to:cc:subject:date:message-id; bh=5J7DlK7zdqI3vBZ/UUOG7WLuTvnTuqa7L0R0xtzH/Ik=; b=RF+ISltW11heKQ/CQ+UxvAjrOcbkRZXvAxnDA6c9ll+NAWbuBG0p/shPsXJjSpPwTe 2Ynq6xhpIpkesNSU3vLsl6pnbmFUr2JQgvtNtFs+AJSNhCggz3jFvZ5UC+AuAgKUHZqs 65HdhKHa4flvd6TGI/WB70WSTPtgcgdPxkSKI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=5J7DlK7zdqI3vBZ/UUOG7WLuTvnTuqa7L0R0xtzH/Ik=; b=It/jxqZyd3TIUHsx8XUlhDIdD7Bll06J8SyKhL0V4VpTuh/Zngp4qx7Wf7AQF0GVDN 2j20oM31vqc5mYYoI6owCQRPIZ15+MM9VdPyGCtrRy1BWdoWhJEmLawOsF3kf8Sn+Wn/ rzOB+n93W6VJRaDPwfSmBh4m/bH3cpGR73Rb0gKmyztDoiATQjjtIIQv9z82FN9DT+FK dEWzqWs/1MzjgjPv5bb5a+IRnHeBZeM6qgefAvopjDLeGuc7xdZxzcxKl4/9wTG2fXPj HvekwFZY68qxSTppJQar7lwkYNQHZ0tnmy6XoLCGWqfT+llBwN8YgilxebMgB/7/So6/ fimw== X-Gm-Message-State: ALoCoQlN2HVOOEF/SWDpa97tScpMfdT1i9I1C5m+F9pXXgTmxNO6B4hwKTH3fE/2pIjnpY/DRPTT X-Received: by 10.52.96.37 with SMTP id dp5mr5646975vdb.17.1427243599005; Tue, 24 Mar 2015 17:33:19 -0700 (PDT) Received: from fedora-devel.home.greyhouse.net (cpe-024-211-243-155.nc.res.rr.com. [24.211.243.155]) by mx.google.com with ESMTPSA id r2sm576133vdr.16.2015.03.24.17.33.18 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Mar 2015 17:33:18 -0700 (PDT) From: Andy Gospodarek To: netdev@vger.kernel.org Cc: Jamal Hadi Salim , Jeff Kirsher , Jiri Pirko , "John W. Linville" , Roopa Prabhu , Scott Feldman , Stephen Hemminger Subject: [PATCH iproute2] iproute2: unify naming for entries offloaded to hardware Date: Tue, 24 Mar 2015 20:33:05 -0400 Message-Id: <1427243585-1530-1-git-send-email-gospo@cumulusnetworks.com> X-Mailer: git-send-email 1.9.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The kernel now has the capability to offload FDB and FIB entries to hardware. It is important to let users know if table entries are also offloaded to hardware. Currently offloaded FDB entries are indicated by the existence of the flag 'external' on the entry as of the following commit: commit 28467b7f3facd6114b2fbe0c9fecf57adbd52e12 Author: Scott Feldman Date: Thu Dec 4 09:57:15 2014 +0100 bridge/fdb: add flag/indication for FDB entry synced from offload device When the patch to add support for indicating that FIB entries were also offloaded as posted to netdev by Scott Feldman it became clear that 'external' would not be an ideal name for routes. There could definitely be confusion about what this might mean since many routes are to external networks -- a collision/confusion that did not happen with FDB. Scott Feldman asked me to check with others and build concensus around a name. After speaking with several people about this I am proposing we refer to both FDB and FIB entries that are currently backed by hardware (based on the work done in rocker) with the flag 'offload' appended to the end ofthe entry. Some people liked the string 'external,' others liked 'hardware,' but the point is to communicate that these routes are available to something that will will offload the forwarding normally done by the kernel. Since the term 'offload' is used so frequently it seems appropriate to use the same language in ip/bridge output. The term 'offload' also seems to resonate with many of the people who have responded on Scott's original thread or to those who I reached out to directly and did respond to my query, so it seems we have reached consensus that it should be the term used going forward. Signed-off-by: Andy Gospodarek CC: Jamal Hadi Salim CC: Jeff Kirsher CC: Jiri Pirko CC: John W. Linville CC: Roopa Prabhu CC: Scott Feldman CC: Stephen Hemminger Acked-by: Scott Feldman Acked-by: Jiri Pirko Acked-by: Simon Horman --- bridge/fdb.c | 2 +- ip/iproute.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/bridge/fdb.c b/bridge/fdb.c index 3c33e22..e34933b 100644 --- a/bridge/fdb.c +++ b/bridge/fdb.c @@ -159,7 +159,7 @@ int print_fdb(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg) if (r->ndm_flags & NTF_ROUTER) fprintf(fp, "router "); if (r->ndm_flags & NTF_EXT_LEARNED) - fprintf(fp, "external "); + fprintf(fp, "offload "); fprintf(fp, "%s\n", state_n2a(r->ndm_state)); return 0; diff --git a/ip/iproute.c b/ip/iproute.c index 024d401..34a5216 100644 --- a/ip/iproute.c +++ b/ip/iproute.c @@ -412,6 +412,8 @@ int print_route(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg) fprintf(fp, "onlink "); if (r->rtm_flags & RTNH_F_PERVASIVE) fprintf(fp, "pervasive "); + if (r->rtm_flags & RTNH_F_EXTERNAL) + fprintf(fp, "offload "); if (r->rtm_flags & RTM_F_NOTIFY) fprintf(fp, "notify "); if (tb[RTA_MARK]) {