From patchwork Wed Mar 4 18:40:03 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Herbert X-Patchwork-Id: 446372 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id D850D14016B for ; Thu, 5 Mar 2015 05:40:34 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="verification failed; unprotected key" header.d=google.com header.i=@google.com header.b=f34L8Qzj; dkim-adsp=none (unprotected policy); dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759616AbbCDSk3 (ORCPT ); Wed, 4 Mar 2015 13:40:29 -0500 Received: from mail-ie0-f180.google.com ([209.85.223.180]:34375 "EHLO mail-ie0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759394AbbCDSk2 (ORCPT ); Wed, 4 Mar 2015 13:40:28 -0500 Received: by iecvy18 with SMTP id vy18so5568694iec.1 for ; Wed, 04 Mar 2015 10:40:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:subject:date:message-id:in-reply-to:references; bh=RdePRqHeeALHdQvG0v6eLndkyxwxMsNQnKrZ4NTr/nk=; b=f34L8QzjxjpCV0+prZ9NAo6zUG4Agj7QVVOz6R1VScHmnT7XznTV8g811qgv3Mn8Io 67r6DsQvsV6TIyGyfRrPQpCZrr7tStaUL89s7v5u5IvLkNd3B+JDdZEhU8XVxNclY/wT ZqoPu4IbKl2UyVG2lafPX7oOuYSQEQ2uiCRE5Az9nGnKHqJPcpLgqIXyevpp7ZdjYA9T hFmaFq3lQO9CpbJSmWYmDsWl2FNHFYZk8Zwgo07eABMiUtDMF4+u+swfnCy8YjAqnQD7 oN90tEqZs2Iv1sZUr767QNULNOxzyzJArEdngwY71at92wu+p1YFwp6HroLlKmqWTreu 4q2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=RdePRqHeeALHdQvG0v6eLndkyxwxMsNQnKrZ4NTr/nk=; b=anP1cFZhzRWd8LF0a1L3slA/r4KtiRW9nrvwqTsnGqm46QFMGqv9VYYyiYbe5Kzm1Y gwYFmY464aDkHPBQlHzTo5W8bgWaeJZPtkGutHwIc6RripnNXicRzi9EZSi3+PKDU3yq aIiNjoftODUx73L7iCpIlzO5LjXmC84AMa9bhnvLiNM7vjfJ31mHoLtSu0iGtAFS6ejZ cyXSRmrI0SNJomXyG1jCiNdEzTOZVJ1k06wvAUipAQtK2eR0cJLidKFJ6Ivw5xP0tEUQ wN6OXQkIBlqyy2CEOzXjiLYwYnsgQ8uSVimAdB+NP7gX9DK1SNnU2y2IL58J5gRe57wb MFSA== X-Gm-Message-State: ALoCoQlTulXKZqj/zUye297gj9P5gFynhdzqHkebY8AKTwK0bWqgU1RjxEp7Z2KEvQdAYbNOd3D8 X-Received: by 10.107.15.156 with SMTP id 28mr14125536iop.57.1425494427325; Wed, 04 Mar 2015 10:40:27 -0800 (PST) Received: from tomh.mtv.corp.google.com ([172.18.117.126]) by mx.google.com with ESMTPSA id qr1sm11161752igb.18.2015.03.04.10.40.26 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 04 Mar 2015 10:40:26 -0800 (PST) From: Tom Herbert To: davem@davemloft.net, netdev@vger.kernel.org, eric.dumazet@gmail.com, fw@strlen.de Subject: [PATCH net-next 5/6] sched: Eliminate use of flow_keys in sch_sfb Date: Wed, 4 Mar 2015 10:40:03 -0800 Message-Id: <1425494404-24114-6-git-send-email-therbert@google.com> X-Mailer: git-send-email 2.2.0.rc0.207.ga3a616c In-Reply-To: <1425494404-24114-1-git-send-email-therbert@google.com> References: <1425494404-24114-1-git-send-email-therbert@google.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Call qdisc_skb_get_hash instead of doing skb_flow_dissect and then jhash by hand. Signed-off-by: Tom Herbert --- net/sched/sch_sfb.c | 24 ++++++++---------------- 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/net/sched/sch_sfb.c b/net/sched/sch_sfb.c index 5819dd8..402d051 100644 --- a/net/sched/sch_sfb.c +++ b/net/sched/sch_sfb.c @@ -26,7 +26,6 @@ #include #include #include -#include /* * SFB uses two B[l][n] : L x N arrays of bins (L levels, N bins per level) @@ -285,9 +284,9 @@ static int sfb_enqueue(struct sk_buff *skb, struct Qdisc *sch) int i; u32 p_min = ~0; u32 minqlen = ~0; - u32 r, slot, salt, sfbhash; + u32 r, sfbhash; + u32 slot = q->slot; int ret = NET_XMIT_SUCCESS | __NET_XMIT_BYPASS; - struct flow_keys keys; if (unlikely(sch->q.qlen >= q->limit)) { qdisc_qstats_overlimit(sch); @@ -309,22 +308,17 @@ static int sfb_enqueue(struct sk_buff *skb, struct Qdisc *sch) fl = rcu_dereference_bh(q->filter_list); if (fl) { + u32 salt; + /* If using external classifiers, get result and record it. */ if (!sfb_classify(skb, fl, &ret, &salt)) goto other_drop; - keys.src = salt; - keys.dst = 0; - keys.ports = 0; + sfbhash = jhash_1word(salt, q->bins[q->slot].perturbation); } else { - skb_flow_dissect(skb, &keys); + sfbhash = skb_get_hash_perturb(skb, q->bins[slot].perturbation); } - slot = q->slot; - sfbhash = jhash_3words((__force u32)keys.dst, - (__force u32)keys.src, - (__force u32)keys.ports, - q->bins[slot].perturbation); if (!sfbhash) sfbhash = 1; sfb_skb_cb(skb)->hashes[slot] = sfbhash; @@ -356,10 +350,8 @@ static int sfb_enqueue(struct sk_buff *skb, struct Qdisc *sch) if (unlikely(p_min >= SFB_MAX_PROB)) { /* Inelastic flow */ if (q->double_buffering) { - sfbhash = jhash_3words((__force u32)keys.dst, - (__force u32)keys.src, - (__force u32)keys.ports, - q->bins[slot].perturbation); + sfbhash = skb_get_hash_perturb(skb, + q->bins[slot].perturbation); if (!sfbhash) sfbhash = 1; sfb_skb_cb(skb)->hashes[slot] = sfbhash;