From patchwork Sun Mar 1 22:09:47 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Herbert X-Patchwork-Id: 444879 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 55102140172 for ; Mon, 2 Mar 2015 09:10:27 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="verification failed; unprotected key" header.d=google.com header.i=@google.com header.b=cLIvlcfk; dkim-adsp=none (unprotected policy); dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753038AbbCAWKY (ORCPT ); Sun, 1 Mar 2015 17:10:24 -0500 Received: from mail-ie0-f169.google.com ([209.85.223.169]:38324 "EHLO mail-ie0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752829AbbCAWKV (ORCPT ); Sun, 1 Mar 2015 17:10:21 -0500 Received: by iecrd18 with SMTP id rd18so43380152iec.5 for ; Sun, 01 Mar 2015 14:10:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:subject:date:message-id:in-reply-to:references; bh=lO5CyKC5r3oaBfk0TlsG2TrOxEU2Ol/k5z6x8KctdFY=; b=cLIvlcfk3tp/Ct8wFcMQukrplaN6EiwdfUf3WHYGCRwxaqWvgb/vkQEyY46UvBTWn3 wxhliPLkw53wNZoOeJlzd7Cl2LhYTOgfcbldXzwaplYWmhomOpdo3LDk5bkRuW6YcGxP GLIPX7sT+bJFdnmRHjjmDghuZECQcj4Gguxz2HoCISJ46xFFplrhZ9s/9OQNiQAO4nWJ xW/GmK0x+bPBmvR2QHGJ/oYO8IOsYrSjRKoErzT+3fUhwcO0TAiHKJOHzyqRNIJYfUtW RMJNSRDq86zv4KsR+kv6E0ko1csRvZvPiuzJ+5zlggkCL3s/O3K2ILUg/cLTmbYAoh8d NwZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=lO5CyKC5r3oaBfk0TlsG2TrOxEU2Ol/k5z6x8KctdFY=; b=gDaqz23rPn/z/J039ckMRj6ZeB54W2o5dLVsToA4gYtMeUzK5ItwYdpWdoxfkgyiej 9hCGokekpJFoc1kFly3eGLqAJnnu4E+Nz2nbRloohaO+EFSUg0w4U8Ti65rexhZkQQnf 8Elg4UImhN0ctOIlEP+RcALbZr8zUlLAjiyww8H4pm0ozPlbKKgp2JgBlvyeVb7DFewa TUgwrgUH7Cqi3RccU1pfOKTBUBlcXo9fF7RFbwPj51DoP26TZIhd7TTQ0MVoP85CQ86C V82Lj2GIurh/rmbhj6FvhT9ystJ7BYFiejwFlq96qsj4prEhsDTAhruigsPyrpp7KtHE Qb6g== X-Gm-Message-State: ALoCoQl91+4t9hfTOec4dJeaq1eEto+CdwJ+PnA73U972EpsTAnqZiyACFwNRgEovoWmYIwGiRay X-Received: by 10.42.150.130 with SMTP id a2mr27711082icw.69.1425247820841; Sun, 01 Mar 2015 14:10:20 -0800 (PST) Received: from tomh.mtv.corp.google.com ([172.18.117.126]) by mx.google.com with ESMTPSA id a196sm6834456ioe.41.2015.03.01.14.10.20 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 01 Mar 2015 14:10:20 -0800 (PST) From: Tom Herbert To: davem@davemloft.net, netdev@vger.kernel.org, eric.dumazet@gmail.com, fw@strlen.de Subject: [PATCH net-next 4/6] sched: Eliminate use of flow_keys in sch_hhf Date: Sun, 1 Mar 2015 14:09:47 -0800 Message-Id: <1425247789-21211-5-git-send-email-therbert@google.com> X-Mailer: git-send-email 2.2.0.rc0.207.ga3a616c In-Reply-To: <1425247789-21211-1-git-send-email-therbert@google.com> References: <1425247789-21211-1-git-send-email-therbert@google.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Call qdisc_skb_get_hash instead of doing skb_flow_dissect and then jhash by hand. Signed-off-by: Tom Herbert --- net/sched/sch_hhf.c | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/net/sched/sch_hhf.c b/net/sched/sch_hhf.c index 15d3aab..9d15cb6 100644 --- a/net/sched/sch_hhf.c +++ b/net/sched/sch_hhf.c @@ -9,7 +9,6 @@ #include #include #include -#include #include #include @@ -176,22 +175,6 @@ static u32 hhf_time_stamp(void) return jiffies; } -static unsigned int skb_hash(const struct hhf_sched_data *q, - const struct sk_buff *skb) -{ - struct flow_keys keys; - unsigned int hash; - - if (skb->sk && skb->sk->sk_hash) - return skb->sk->sk_hash; - - skb_flow_dissect(skb, &keys); - hash = jhash_3words((__force u32)keys.dst, - (__force u32)keys.src ^ keys.ip_proto, - (__force u32)keys.ports, q->perturbation); - return hash; -} - /* Looks up a heavy-hitter flow in a chaining list of table T. */ static struct hh_flow_state *seek_list(const u32 hash, struct list_head *head, @@ -280,7 +263,7 @@ static enum wdrr_bucket_idx hhf_classify(struct sk_buff *skb, struct Qdisc *sch) } /* Get hashed flow-id of the skb. */ - hash = skb_hash(q, skb); + hash = skb_get_hash_perturb(skb, q->perturbation); /* Check if this packet belongs to an already established HH flow. */ flow_pos = hash & HHF_BIT_MASK;