From patchwork Sat Feb 7 02:17:31 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rasmus Villemoes X-Patchwork-Id: 437507 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 0E9CE140270 for ; Sat, 7 Feb 2015 13:18:04 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755064AbbBGCRm (ORCPT ); Fri, 6 Feb 2015 21:17:42 -0500 Received: from mail-lb0-f177.google.com ([209.85.217.177]:37407 "EHLO mail-lb0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754021AbbBGCRl (ORCPT ); Fri, 6 Feb 2015 21:17:41 -0500 Received: by mail-lb0-f177.google.com with SMTP id p9so21140262lbv.8 for ; Fri, 06 Feb 2015 18:17:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=from:to:cc:subject:date:message-id; bh=zBYm9JbtxvuHVO42h4oAeZiQzATF+qLei/jHRfEBOMQ=; b=aAZSJKU68EO7Y8+S6lrstpzP76UTUfxyrysM+KpjCJiLKvkHQOVNKSGuVAuMESFAPQ XsgY/jZHea9Z6Nge5IKAdrjOLRzM2+tcHmDuZkJCkEl1AHWZQuLeihDA/ucgVx1vc0TS c+e0ndBhEiQ72Y3DW9sVAtrj1F8YmAQ9fdm30= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=zBYm9JbtxvuHVO42h4oAeZiQzATF+qLei/jHRfEBOMQ=; b=aspXP0GjK1drSlAIJu2qOy1d/kMQupiGAGSe+qkfj0CIAPAhxPYHTMEjfqHjorM8Ul 3okGUTabys6WZjZuedrSMMtCo/oyhdGWIGo5k4XhRvMxgXhTZxm0uUi3SQWoV2SBR4JZ O6VcG/ERvh5kzAbX66Oa0pJKG+StTSNkJj7X0IoZ97vkk/cxdiu8FYealmnu/jYeynpb FMarYafiiWB56tm003C1E4gNIp3cnu+rTymSAV4MaXP4d3NemkCDdAsjTk4vQw4uv5mC t7JknTIN5enOs2mVcStFLY8OXpqywf9H6r6u6R3I1xHUyBi55r6zApItmxe/QK5N/jPI pQUw== X-Gm-Message-State: ALoCoQlt1vCoYUE2hFTOriTEZEo+r3BOvbbhDAuqDKVsw4tpu+Xv0c9RbJJkEI7yhgXgrGEFl7IY X-Received: by 10.152.161.204 with SMTP id xu12mr5673624lab.12.1423275459208; Fri, 06 Feb 2015 18:17:39 -0800 (PST) Received: from spencer.imf.au.dk ([130.225.20.51]) by mx.google.com with ESMTPSA id uh6sm700586lac.5.2015.02.06.18.17.38 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Feb 2015 18:17:38 -0800 (PST) From: Rasmus Villemoes To: "David S. Miller" , Pravin B Shelar , Nicolas Dichtel Cc: Rasmus Villemoes , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] vxlan: Wrong type passed to %pIS Date: Sat, 7 Feb 2015 03:17:31 +0100 Message-Id: <1423275451-3663-1-git-send-email-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.1.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org src_ip is a pointer to a union vxlan_addr, one member of which is a struct sockaddr. Passing a pointer to src_ip is wrong; one should pass the value of src_ip itself. Since %pIS formally expects something of type struct sockaddr*, let's pass a pointer to the appropriate union member, though this of course doesn't change the generated code. Fixes: e4c7ed415387 ("vxlan: add ipv6 support") Signed-off-by: Rasmus Villemoes Acked-by: Cong Wang --- drivers/net/vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index a8c755dcab14..11defbb24183 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -991,7 +991,7 @@ static bool vxlan_snoop(struct net_device *dev, if (net_ratelimit()) netdev_info(dev, "%pM migrated from %pIS to %pIS\n", - src_mac, &rdst->remote_ip, &src_ip); + src_mac, &rdst->remote_ip.sa, &src_ip->sa); rdst->remote_ip = *src_ip; f->updated = jiffies;