From patchwork Thu Feb 5 16:21:07 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prabhakar X-Patchwork-Id: 436866 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 0B19A140291 for ; Fri, 6 Feb 2015 03:21:52 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757678AbbBEQVh (ORCPT ); Thu, 5 Feb 2015 11:21:37 -0500 Received: from mail-wg0-f52.google.com ([74.125.82.52]:37335 "EHLO mail-wg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757572AbbBEQVg (ORCPT ); Thu, 5 Feb 2015 11:21:36 -0500 Received: by mail-wg0-f52.google.com with SMTP id y19so8470970wgg.11; Thu, 05 Feb 2015 08:21:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=2gD3BtF4J1CMprgoqpOdUXAgyyoXOglCwuEH03NRlsA=; b=EPwZ0b4UhUMInToKnSvc1ULnn1CDhYrhrmb0DQaKNOR8jrRpxINymYNH2WIL17pW+0 kHkio/6IMtNYcfdpiQWKCtCFAd4eO6Ya19CjnUHiXY5WS3JXZIPQvywI21403cueuZfi FAkKwBiKNModtx+uxoJwFVNJrpiv3Ue9GtlT2qpe6JEi1kzPuoRoDMJJsGHK9F2TDDlv X7JhkXVNVHj8J6ARQQY5R6n6mQ3cE4/DsLje8/CUegG+kOhjNEV6YKbErVWb+h9qoYFQ QMhlU/SosAiahi9ZGF3EwBO/OUMUihVQQf2Hm6fBumYDwqJgdnlKvhd4KwKvMirNYGhB uwvQ== X-Received: by 10.180.35.42 with SMTP id e10mr16574309wij.11.1423153294745; Thu, 05 Feb 2015 08:21:34 -0800 (PST) Received: from tango-charlie.RL.local ([194.72.83.162]) by mx.google.com with ESMTPSA id q4sm8545486wiz.4.2015.02.05.08.21.33 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 05 Feb 2015 08:21:33 -0800 (PST) From: Lad Prabhakar To: Nicolas Ferre , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "Lad, Prabhakar" Subject: [PATCH v2] net/macb: fix sparse warning Date: Thu, 5 Feb 2015 16:21:07 +0000 Message-Id: <1423153267-1768-1-git-send-email-prabhakar.csengg@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Lad, Prabhakar" this patch fixes following sparse warning: macb.c:2038:26: warning: symbol 'gem_ethtool_ops' was not declared. Should it be static? Alongside drops exporting of gem_ethtool_ops as there is no need. Signed-off-by: Lad, Prabhakar Acked-by: Nicolas Ferre --- Found this issue on linux-next (gcc version 4.8.2, sparse version 0.4.5-rc1)and applies on top linux-next. drivers/net/ethernet/cadence/macb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c index 4f7bd13..ad76b8e 100644 --- a/drivers/net/ethernet/cadence/macb.c +++ b/drivers/net/ethernet/cadence/macb.c @@ -2035,7 +2035,7 @@ const struct ethtool_ops macb_ethtool_ops = { }; EXPORT_SYMBOL_GPL(macb_ethtool_ops); -const struct ethtool_ops gem_ethtool_ops = { +static const struct ethtool_ops gem_ethtool_ops = { .get_settings = macb_get_settings, .set_settings = macb_set_settings, .get_regs_len = macb_get_regs_len, @@ -2046,7 +2046,6 @@ const struct ethtool_ops gem_ethtool_ops = { .get_strings = gem_get_ethtool_strings, .get_sset_count = gem_get_sset_count, }; -EXPORT_SYMBOL_GPL(gem_ethtool_ops); int macb_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) {