From patchwork Thu Feb 5 15:47:17 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prabhakar X-Patchwork-Id: 436858 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 91B9F140276 for ; Fri, 6 Feb 2015 02:47:46 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757951AbbBEPrb (ORCPT ); Thu, 5 Feb 2015 10:47:31 -0500 Received: from mail-wg0-f47.google.com ([74.125.82.47]:38029 "EHLO mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753747AbbBEPra (ORCPT ); Thu, 5 Feb 2015 10:47:30 -0500 Received: by mail-wg0-f47.google.com with SMTP id n12so8341688wgh.6; Thu, 05 Feb 2015 07:47:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=VNREU0p1T7pXiXC6Qx8Cxx+AWucQqLPFuJC6pIwAnh0=; b=uMm/948ZZvpmXH8Db8QQexjdptDyhaCnCCJGzONhjFYN894aOzE4sLwvHyUGhTD/mD oHLwmEkrAXoN/Jh9jYquE1aEIau9lMrPb/eug0ssUCcGYsE8++a6vK7a1BbRC//K62ZE g4waELd8E8SfIU71ik12mQbuL0vj2jUSqiW72AhlvdwU27hBMy4lh/DsLPKOVAlOUDkL BPNxYp//H/l71cLtnAmoHKqa0urP+IPsvjAUVkbTH/2G7xXxvpSXG8CRu7J82aec1YUu j1bZ5Hu0m9wyQYzwlQXNLuJEFWTKsEIhXS/uxD0xsUfJeCSHK8w9GNV6djipTCELeyu+ J0tQ== X-Received: by 10.180.126.98 with SMTP id mx2mr8630156wib.18.1423151248758; Thu, 05 Feb 2015 07:47:28 -0800 (PST) Received: from tango-charlie.RL.local ([194.72.83.162]) by mx.google.com with ESMTPSA id er13sm7906801wjc.11.2015.02.05.07.47.27 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 05 Feb 2015 07:47:27 -0800 (PST) From: Lad Prabhakar To: Ariel Elior , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "Lad, Prabhakar" Subject: [PATCH] net: bnx2x: fix sparse warnings Date: Thu, 5 Feb 2015 15:47:17 +0000 Message-Id: <1423151237-20746-1-git-send-email-prabhakar.csengg@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Lad, Prabhakar" this patch fixes following sparse warnings: bnx2x_main.c:9172:6: warning: symbol 'bnx2x_stop_ptp' was not declared. Should it be static? bnx2x_main.c:13321:6: warning: symbol 'bnx2x_register_phc' was not declared. Should it be static? bnx2x_main.c:14638:5: warning: symbol 'bnx2x_enable_ptp_packets' was not declared. Should it be static? Signed-off-by: Lad, Prabhakar Acked-by: Eric Dumazet --- Found this issue on linux-next (gcc version 4.8.2, sparse version 0.4.5-rc1)and applies on top linux-next. drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c index 0758c8b..7155e1d 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c @@ -9169,7 +9169,7 @@ static void bnx2x_disable_ptp(struct bnx2x *bp) } /* Called during unload, to stop PTP-related stuff */ -void bnx2x_stop_ptp(struct bnx2x *bp) +static void bnx2x_stop_ptp(struct bnx2x *bp) { /* Cancel PTP work queue. Should be done after the Tx queues are * drained to prevent additional scheduling. @@ -13318,7 +13318,7 @@ static int bnx2x_ptp_enable(struct ptp_clock_info *ptp, return -ENOTSUPP; } -void bnx2x_register_phc(struct bnx2x *bp) +static void bnx2x_register_phc(struct bnx2x *bp) { /* Fill the ptp_clock_info struct and register PTP clock*/ bp->ptp_clock_info.owner = THIS_MODULE; @@ -14635,7 +14635,7 @@ static int bnx2x_send_reset_timesync_ramrod(struct bnx2x *bp) return bnx2x_func_state_change(bp, &func_params); } -int bnx2x_enable_ptp_packets(struct bnx2x *bp) +static int bnx2x_enable_ptp_packets(struct bnx2x *bp) { struct bnx2x_queue_state_params q_params; int rc, i;