From patchwork Thu Feb 5 15:40:46 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prabhakar X-Patchwork-Id: 436846 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id D66D7140276 for ; Fri, 6 Feb 2015 02:41:39 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757839AbbBEPlD (ORCPT ); Thu, 5 Feb 2015 10:41:03 -0500 Received: from mail-we0-f171.google.com ([74.125.82.171]:63400 "EHLO mail-we0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753763AbbBEPlC (ORCPT ); Thu, 5 Feb 2015 10:41:02 -0500 Received: by mail-we0-f171.google.com with SMTP id k11so8422304wes.2; Thu, 05 Feb 2015 07:41:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=fYiXIgjj6XveQmwmVwvX5xSyB+7tJ8WLHxTNPrKuu6A=; b=N7j2sOTokKAWRhznyMTCmVSctOVUvTs+/JENWabJ2hlneLk5UuCM5yGG2z4mhb2aYt nVl/FAuSYNK2wB/PZfcoM35w3+fKTpb8aaXqF3YuAOvQyZKpyazlEsB/sa2gJDeYN7ZE ipj0970p4YkhIQfOnIVxxWVEaugEtLDVt6AseC+ykmaK3+30DR1Fap7b3ZIKH17/Ci/7 ihSjvesUQPgx4P7G1TCTYxg3Mag7MDqfAr10GZtJS3vfLpN52oYCmmfoJTfEnCUvGX1z m7jkG+TGGfLsMvf4NqpctcfV7FMeXET/pm4UxnQqMZCy5YzdMbHkJ+b5I6QXq1ZczXLj OFZg== X-Received: by 10.194.240.99 with SMTP id vz3mr8933592wjc.37.1423150860434; Thu, 05 Feb 2015 07:41:00 -0800 (PST) Received: from tango-charlie.RL.local ([194.72.83.162]) by mx.google.com with ESMTPSA id di11sm8390593wid.8.2015.02.05.07.40.59 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 05 Feb 2015 07:40:59 -0800 (PST) From: Lad Prabhakar To: Nicolas Ferre , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "Lad, Prabhakar" Subject: [PATCH] net/macb: fix sparse warning Date: Thu, 5 Feb 2015 15:40:46 +0000 Message-Id: <1423150846-7027-1-git-send-email-prabhakar.csengg@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Lad, Prabhakar" this patch fixes following sparse warning: macb.c:2038:26: warning: symbol 'gem_ethtool_ops' was not declared. Should it be static? Signed-off-by: Lad, Prabhakar --- Found this issue on linux-next (gcc version 4.8.2, sparse version 0.4.5-rc1)and applies on top linux-next. drivers/net/ethernet/cadence/macb.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h index 31dc080..e6ad68a 100644 --- a/drivers/net/ethernet/cadence/macb.h +++ b/drivers/net/ethernet/cadence/macb.h @@ -821,6 +821,7 @@ struct macb { }; extern const struct ethtool_ops macb_ethtool_ops; +extern const struct ethtool_ops gem_ethtool_ops; int macb_mii_init(struct macb *bp); int macb_ioctl(struct net_device *dev, struct ifreq *rq, int cmd);