| Message ID | 1423150846-7027-1-git-send-email-prabhakar.csengg@gmail.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
Le 05/02/2015 16:40, Lad Prabhakar a écrit : > From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com> > > this patch fixes following sparse warning: > > macb.c:2038:26: warning: symbol 'gem_ethtool_ops' was not declared. Should it be static? Well, actually this function doesn't need to be exported and indeed should be marked as static. I'm not against this patch, but removing the export macro and making it as static should do the trick even better. Bye, > Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com> > --- > Found this issue on linux-next (gcc version 4.8.2, > sparse version 0.4.5-rc1)and applies on top linux-next. > > drivers/net/ethernet/cadence/macb.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h > index 31dc080..e6ad68a 100644 > --- a/drivers/net/ethernet/cadence/macb.h > +++ b/drivers/net/ethernet/cadence/macb.h > @@ -821,6 +821,7 @@ struct macb { > }; > > extern const struct ethtool_ops macb_ethtool_ops; > +extern const struct ethtool_ops gem_ethtool_ops; > > int macb_mii_init(struct macb *bp); > int macb_ioctl(struct net_device *dev, struct ifreq *rq, int cmd); >
On Thu, Feb 5, 2015 at 4:06 PM, Nicolas Ferre <nicolas.ferre@atmel.com> wrote: > Le 05/02/2015 16:40, Lad Prabhakar a écrit : >> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com> >> >> this patch fixes following sparse warning: >> >> macb.c:2038:26: warning: symbol 'gem_ethtool_ops' was not declared. Should it be static? > > Well, actually this function doesn't need to be exported and indeed > should be marked as static. > > I'm not against this patch, but removing the export macro and making it > as static should do the trick even better. > Done! [1] https://patchwork.kernel.org/patch/5785511/ Cheers, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h index 31dc080..e6ad68a 100644 --- a/drivers/net/ethernet/cadence/macb.h +++ b/drivers/net/ethernet/cadence/macb.h @@ -821,6 +821,7 @@ struct macb { }; extern const struct ethtool_ops macb_ethtool_ops; +extern const struct ethtool_ops gem_ethtool_ops; int macb_mii_init(struct macb *bp); int macb_ioctl(struct net_device *dev, struct ifreq *rq, int cmd);