From patchwork Thu Feb 5 15:20:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prabhakar X-Patchwork-Id: 436842 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 95A7B14028F for ; Fri, 6 Feb 2015 02:20:39 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753667AbbBEPUY (ORCPT ); Thu, 5 Feb 2015 10:20:24 -0500 Received: from mail-wi0-f176.google.com ([209.85.212.176]:48438 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752850AbbBEPUX (ORCPT ); Thu, 5 Feb 2015 10:20:23 -0500 Received: by mail-wi0-f176.google.com with SMTP id bs8so39748127wib.3; Thu, 05 Feb 2015 07:20:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=fHzVhd0JWgk4Jjhm+buwjpbDeAujAfCGB9/T0FAR/xM=; b=oYr0Pfh+N/eZphTRfjqnyyVV3UnyXp3kriSJLpAiNWpDgcxqVO27u2dLOoenATh6qR 3s+jht648j/3PyPSsie4Bn1na1el8NNKMmXzbyHSBZh5DbNP9aNWe4GAOY7hXF92rcLm PPLMrnoELMdMiNPMAszBI7+tW3Ctqk40i0XtwFaYXi13f1leeWmbiQXwpBF1pV1PV/vo dfjsr9VOVz1grdkRYC0NzzAOKIY7EUN8gCjCl+0jJO9tOiWyueLa2QVK2QrOxbmiGZPx IproYqbT5ZaXphrcc7GShQdmaFp3eVmzKfZ3yHAb6r+UWMF+BiRgWfamMAyIG4woX63A 38Zg== X-Received: by 10.194.120.40 with SMTP id kz8mr8902179wjb.21.1423149621523; Thu, 05 Feb 2015 07:20:21 -0800 (PST) Received: from tango-charlie.RL.local ([194.72.83.162]) by mx.google.com with ESMTPSA id ha1sm34298203wib.24.2015.02.05.07.20.20 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 05 Feb 2015 07:20:20 -0800 (PST) From: Lad Prabhakar To: Hariprasad S , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "Lad, Prabhakar" Subject: [PATCH] chelsio: cxgb4: fix sparse warning Date: Thu, 5 Feb 2015 15:20:09 +0000 Message-Id: <1423149609-24108-1-git-send-email-prabhakar.csengg@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Lad, Prabhakar" this patch fixes following sparse warning: cxgb4_dcb.c:25:6: warning: symbol 'dcb_ver_array' was not declared. Should it be static? Alongside making it const. Signed-off-by: Lad, Prabhakar --- Found this issue on linux-next (gcc version 4.8.2, sparse version 0.4.5-rc1)and applies on top linux-next. drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c index b65a5bd..6074680 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c @@ -22,7 +22,7 @@ /* DCBx version control */ -char *dcb_ver_array[] = { +static const char * const dcb_ver_array[] = { "Unknown", "DCBx-CIN", "DCBx-CEE 1.01",