Message ID | 1423149195-32142-1-git-send-email-prabhakar.csengg@gmail.com |
---|---|
State | Awaiting Upstream, archived |
Delegated to: | David Miller |
Headers | show |
On Thu, 2015-02-05 at 15:13 +0000, Lad Prabhakar wrote: > From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com> > > this patch fixes following sparse warning: > > i40e_lan_hmc.c:911:24: warning: constant 0xFFFFFFFFFFFFFFFF is so big > it is unsigned long > > Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com> > --- > Found this issue on linux-next (gcc version 4.8.2, > sparse version 0.4.5-rc1)and applies on top linux-next. > > drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I already have a fix in my queue to resolve this issue, so I am dropping your patch.
diff --git a/drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c b/drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c index 4627588..f221ace 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c +++ b/drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c @@ -908,7 +908,7 @@ static void i40e_write_qword(u8 *hmc_bits, if (ce_info->width < 64) mask = ((u64)1 << ce_info->width) - 1; else - mask = 0xFFFFFFFFFFFFFFFF; + mask = 0xFFFFFFFFFFFFFFFFULL; /* don't swizzle the bits until after the mask because the mask bits * will be in a different bit position on big endian machines