From patchwork Thu Feb 5 15:06:33 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prabhakar X-Patchwork-Id: 436839 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3FFF1140276 for ; Fri, 6 Feb 2015 02:07:18 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757626AbbBEPGy (ORCPT ); Thu, 5 Feb 2015 10:06:54 -0500 Received: from mail-wg0-f52.google.com ([74.125.82.52]:58334 "EHLO mail-wg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751439AbbBEPGx (ORCPT ); Thu, 5 Feb 2015 10:06:53 -0500 Received: by mail-wg0-f52.google.com with SMTP id y19so8059131wgg.11; Thu, 05 Feb 2015 07:06:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=UCB4gL0wVuMZsEsRJ2zeRHaqQ6iR0svOxUaUME7RFds=; b=y5u7Z9X+lVn8njrQLtDwFSgX37BDwrr0xC6x3gw9+QPJMDUiLS+IdhqJJJXTYU2eS3 5dYGoN3uhq8Chu1Zw48u+kH/SG+q5yhxdaStRjEoIHVe20HDfAuiPaJf6SkyAV0c/QtB BPDETPXjgV7xGsOQSXDyaI+1xSNTzwMFKADTGToAxQ6cebualtpZ8pzRZWFLkZuAZM0A dHsejtBYyy7T6m165VdIFxxtBgg+K/jI8ArJwrAobdOv3ksm+AWzzLnqVJF1InWmmCdK FZmSY1TK73LZrWSR352FNzSgG/QnEYBlLBR1C9+j/cAnVYyqWs/K8hq+PqdQJ/ibIUjl g4Pg== X-Received: by 10.180.188.203 with SMTP id gc11mr56821661wic.65.1423148812051; Thu, 05 Feb 2015 07:06:52 -0800 (PST) Received: from tango-charlie.RL.local ([194.72.83.162]) by mx.google.com with ESMTPSA id n1sm26348999wib.11.2015.02.05.07.06.51 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 05 Feb 2015 07:06:51 -0800 (PST) From: Lad Prabhakar To: "K. Y. Srinivasan" , Haiyang Zhang , devel@linuxdriverproject.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Lad, Prabhakar" Subject: [PATCH] hyperv: fix sparse warnings Date: Thu, 5 Feb 2015 15:06:33 +0000 Message-Id: <1423148793-19610-1-git-send-email-prabhakar.csengg@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Lad, Prabhakar" this patch fixes following sparse warnings: netvsc.c:688:5: warning: symbol 'netvsc_copy_to_send_buf' was not declared. Should it be static? rndis_filter.c:627:5: warning: symbol 'rndis_filter_set_offload_params' was not declared. Should it be static? rndis_filter.c:702:5: warning: symbol 'rndis_filter_set_rss_param' was not declared. Should it be static? Signed-off-by: Lad, Prabhakar Signed-off-by: Haiyang Zhang --- Found this issue on linux-next (gcc version 4.9.2, sparse version 0.4.5-rc1) and applies on top linux-next. drivers/net/hyperv/netvsc.c | 6 +++--- drivers/net/hyperv/rndis_filter.c | 5 +++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c index 58bb410..208eb05 100644 --- a/drivers/net/hyperv/netvsc.c +++ b/drivers/net/hyperv/netvsc.c @@ -685,9 +685,9 @@ static u32 netvsc_get_next_send_section(struct netvsc_device *net_device) return ret_val; } -u32 netvsc_copy_to_send_buf(struct netvsc_device *net_device, - unsigned int section_index, - struct hv_netvsc_packet *packet) +static u32 netvsc_copy_to_send_buf(struct netvsc_device *net_device, + unsigned int section_index, + struct hv_netvsc_packet *packet) { char *start = net_device->send_buf; char *dest = (start + (section_index * net_device->send_section_size)); diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c index 7bd8387..7816d98 100644 --- a/drivers/net/hyperv/rndis_filter.c +++ b/drivers/net/hyperv/rndis_filter.c @@ -624,7 +624,8 @@ cleanup: return ret; } -int rndis_filter_set_offload_params(struct hv_device *hdev, +static int +rndis_filter_set_offload_params(struct hv_device *hdev, struct ndis_offload_params *req_offloads) { struct netvsc_device *nvdev = hv_get_drvdata(hdev); @@ -699,7 +700,7 @@ u8 netvsc_hash_key[HASH_KEYLEN] = { 0x6a, 0x42, 0xb7, 0x3b, 0xbe, 0xac, 0x01, 0xfa }; -int rndis_filter_set_rss_param(struct rndis_device *rdev, int num_queue) +static int rndis_filter_set_rss_param(struct rndis_device *rdev, int num_queue) { struct net_device *ndev = rdev->net_dev->ndev; struct rndis_request *request;