From patchwork Wed Feb 4 12:25:46 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prabhakar X-Patchwork-Id: 436320 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 7A98414017F for ; Wed, 4 Feb 2015 23:26:16 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933488AbbBDM0F (ORCPT ); Wed, 4 Feb 2015 07:26:05 -0500 Received: from mail-wg0-f44.google.com ([74.125.82.44]:38966 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755277AbbBDM0C (ORCPT ); Wed, 4 Feb 2015 07:26:02 -0500 Received: by mail-wg0-f44.google.com with SMTP id z12so1432695wgg.3; Wed, 04 Feb 2015 04:26:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=AvBlSE7704qYE0ULIWFPqlXBR7ZA1xxx4qerECwalmg=; b=Iy1Zv8PJbKVz1n8kO/yu+J2ULMnWbwWuc6QmR8Q7tMrN3d7B5KBXu38Fr4qVDpxwk6 WMMgoESxibdWLjyJUtA4sYk6jZqoDfQ/lJUwx5N2w8eNb+8vSxB/H6uS4yJrifad2i+8 00GUFMuNO8CM6/A0Lo7TCEoDmX5FsC0UKGvk3XXrvY5F5OvZtgOZfpwdWeqDomIDoO7j OWHverK0tsS7FAd7HSjDA6ftgvnFkKU1+vGCdg3krrVL/nyO89DDEg/JUhRf389Rzczp 0Z6Q6bA7NxP1XjUcSjE4acDvr0wEjO4OZE98soemicey7Ifh6BnY+yzoybjwTl/DjW0l 1dKQ== X-Received: by 10.194.23.39 with SMTP id j7mr66995549wjf.9.1423052760965; Wed, 04 Feb 2015 04:26:00 -0800 (PST) Received: from tango-charlie.RL.local ([194.72.83.162]) by mx.google.com with ESMTPSA id hl1sm2513843wjc.18.2015.02.04.04.26.00 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 04 Feb 2015 04:26:00 -0800 (PST) From: Lad Prabhakar To: "David S. Miller" , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Eric Dumazet , "Lad, Prabhakar" Subject: [PATCH] net: core/dev: fix sparse warning Date: Wed, 4 Feb 2015 12:25:46 +0000 Message-Id: <1423052746-3688-1-git-send-email-prabhakar.csengg@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Lad, Prabhakar" this patch fixes following sparse warning: net/core/dev.c: In function 'validate_xmit_skb_list': net/core/dev.c:2720: warning: 'tail' may be used uninitialized in this function Although its a false positive, as head is assigned to NULL in the beginning, due which later in the loop tail is assigned to skb->prev. Signed-off-by: Lad, Prabhakar --- net/core/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/dev.c b/net/core/dev.c index 8ce0d1a..c736467 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -2717,7 +2717,7 @@ out_null: struct sk_buff *validate_xmit_skb_list(struct sk_buff *skb, struct net_device *dev) { - struct sk_buff *next, *head = NULL, *tail; + struct sk_buff *next, *head = NULL, *tail = NULL; for (; skb != NULL; skb = next) { next = skb->next;