From patchwork Wed Jan 14 07:52:35 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Poirier X-Patchwork-Id: 428828 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id B59AA1400EA for ; Wed, 14 Jan 2015 18:54:06 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933186AbbANHyC (ORCPT ); Wed, 14 Jan 2015 02:54:02 -0500 Received: from mail-pd0-f170.google.com ([209.85.192.170]:59577 "EHLO mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932741AbbANHx6 (ORCPT ); Wed, 14 Jan 2015 02:53:58 -0500 Received: by mail-pd0-f170.google.com with SMTP id v10so8365204pde.1; Tue, 13 Jan 2015 23:53:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=/y7XQSVQ4CiaKwalwdbmDfTSHZHRBzS8Goh7IAbAGgM=; b=cHkRMVIHJpinuoRckyZfZdmAN0/0cSUc/LHGbRZ3Jp/M8/BpGKvDyPGBduQP1WCaOj HhIYz7GWS/ncV/D8ha/EnxllyX8IQ5BJb1vaeFtzjdvzu6CORXa3jF/1cPSZY4OlWfq8 G+0FkM4n1dgIK/WC3eGYZOjWOw0o4XKSOQhQN+T/wUIdjTJzzMXiq/3RYWiencuCjIoN 0t0LUa9Lol4ibI33IkWcqjn8XmiuMQpypBt+bJGAm6LLH7rJhYGDLRHc5rjfabS6/m4z 3HvRc0thBM18mkUCZ8p258vdpROtXV44gBXZE21elpialts6pMvJA67AVpxbBP3Ou5T9 zEjA== X-Received: by 10.66.251.167 with SMTP id zl7mr3756593pac.140.1421222038234; Tue, 13 Jan 2015 23:53:58 -0800 (PST) Received: from f1.synalogic.ca (e0109-106-188-2-13.uqwimax.jp. [106.188.2.13]) by mx.google.com with ESMTPSA id o10sm18935747pdr.96.2015.01.13.23.53.55 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 13 Jan 2015 23:53:57 -0800 (PST) From: Benjamin Poirier To: "David S. Miller" Cc: Nikolay Aleksandrov , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] netdevice: Add missing parentheses in macro Date: Wed, 14 Jan 2015 16:52:35 +0900 Message-Id: <1421221955-9505-1-git-send-email-bpoirier@suse.de> X-Mailer: git-send-email 2.2.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org For example, one could conceivably call for_each_netdev_in_bond_rcu(condition ? bond1 : bond2, slave) and get an unexpected result. Signed-off-by: Benjamin Poirier --- include/linux/netdevice.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 7f794db..52fd8e8 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -2085,7 +2085,7 @@ extern rwlock_t dev_base_lock; /* Device list lock */ list_for_each_entry_continue_rcu(d, &(net)->dev_base_head, dev_list) #define for_each_netdev_in_bond_rcu(bond, slave) \ for_each_netdev_rcu(&init_net, slave) \ - if (netdev_master_upper_dev_get_rcu(slave) == bond) + if (netdev_master_upper_dev_get_rcu(slave) == (bond)) #define net_device_entry(lh) list_entry(lh, struct net_device, dev_list) static inline struct net_device *next_net_device(struct net_device *dev)