From patchwork Wed Jan 7 19:26:38 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vlad Zolotarov X-Patchwork-Id: 426381 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 117221400B7 for ; Thu, 8 Jan 2015 06:27:08 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754578AbbAGT1D (ORCPT ); Wed, 7 Jan 2015 14:27:03 -0500 Received: from mail-wi0-f177.google.com ([209.85.212.177]:41286 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754316AbbAGT1A (ORCPT ); Wed, 7 Jan 2015 14:27:00 -0500 Received: by mail-wi0-f177.google.com with SMTP id l15so2361280wiw.4 for ; Wed, 07 Jan 2015 11:26:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=wJvUR7/s6XXlO4ivNbSLEWWcbfL3bZpUvf9C+hpXG1o=; b=MaTHBq9JepzDTEMYZV1ameHAvnyHIMINs3plX0MDCFaS0DySOJr+7v06ql8NN+/rVJ DdDAfYO2YRzMbt4xho7fQViW+uBJEhQqGrJ/o8hL9D4Mscs7SqGrPPCZfko9+/fs3Yqh VRe7+tPNr//IJvPGi3jjJECmmiE4A4leO1Gt8g5j6UQcJ9KS03hhK+1dEKsTo3yySQka ePvJFfCJIXxcQ2WGZ6aICcxajPFlmElKw6HdfRtv88/jP/4loyxQ5YabjBWciCYU4i48 CM0U1WnhQKQaUT6MhJzgzt0yLaJNpzxYqZ14cVQIfXL+GDs7eu2a/Ee7bqc+IOBePazH NLwg== X-Gm-Message-State: ALoCoQkPzXH6+o+K45XIygYk2TbIH2S95L2Pe/KHAsma6fVL0cxiVqz0/LekBhWBW5/3DMJ49D07 X-Received: by 10.194.239.233 with SMTP id vv9mr9567706wjc.90.1420658818771; Wed, 07 Jan 2015 11:26:58 -0800 (PST) Received: from vladz-laptop.localdomain ([109.66.164.96]) by mx.google.com with ESMTPSA id cs8sm19008663wib.1.2015.01.07.11.26.57 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Jan 2015 11:26:58 -0800 (PST) From: Vlad Zolotarov To: netdev@vger.kernel.org Cc: gleb@cloudius-systems.com, avi@cloudius-systems.com, jeffrey.t.kirsher@intel.com, Vlad Zolotarov Subject: [PATCH net-next v5 3/7] ixgbe: Add a RETA query command to VF-PF channel API Date: Wed, 7 Jan 2015 21:26:38 +0200 Message-Id: <1420658802-18061-4-git-send-email-vladz@cloudius-systems.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1420658802-18061-1-git-send-email-vladz@cloudius-systems.com> References: <1420658802-18061-1-git-send-email-vladz@cloudius-systems.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org 82599 and x540 VFs and PF share the same RSS redirection table (RETA). Therefore we just return it for all VFs. x550 on the other hand provides a separate redirection table for each VF (there is a per-pool RETA table). For 82599 and x540 RETA table is an array of 32 registers (128 bytes) and the maximum number of registers that may be delivered in a single VF-PF channel command is 15. Therefore we will deliver the whole table in 3 steps: 12, 12 and 8 registers in each step correspondingly. For x550 VFs RETA is a 64 byte array, so we may deliver it in two steps: 12 and 4 registers correspondingly. Thus this patch does the following: - Adds a new API version (to specify a new commands set). - Adds the IXGBE_VF_GET_RETA command to the VF-PF commands set. Signed-off-by: Vlad Zolotarov --- New in v5: - Use the newly added netdev op to allow/prevent the RETA query on a per-VF basis. New in v4: - Deleted an empty line in ixgbe_get_vf_reta() switch-case. New in v3: - Pass the number of dwords and offset in RETA in the IXGBE_VF_GET_RETA request message. This allows to reduce the added command set to a single command. - Added a support for all devices supported by the ixgbe driver that have SR-IOV functions support: 82599, x540 and x550. The original code supported only 82599 and x540. - Added the masking of the RETA entries according to the PSRTYPE[n].RQPL value. New in v1 (compared to RFC): - Use "if-else" statement instead of a "switch-case" for a single option case (in ixgbe_get_vf_reta()). --- drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h | 8 ++++ drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 65 ++++++++++++++++++++++++++ 2 files changed, 73 insertions(+) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h b/drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h index a5cb755..f9b5eae 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h @@ -73,6 +73,7 @@ enum ixgbe_pfvf_api_rev { ixgbe_mbox_api_10, /* API version 1.0, linux/freebsd VF driver */ ixgbe_mbox_api_20, /* API version 2.0, solaris Phase1 VF driver */ ixgbe_mbox_api_11, /* API version 1.1, linux/freebsd VF driver */ + ixgbe_mbox_api_12, /* API version 1.2, linux/freebsd VF driver */ /* This value should always be last */ ixgbe_mbox_api_unknown, /* indicates that API version is not known */ }; @@ -97,6 +98,13 @@ enum ixgbe_pfvf_api_rev { #define IXGBE_VF_TRANS_VLAN 3 /* Indication of port vlan */ #define IXGBE_VF_DEF_QUEUE 4 /* Default queue offset */ +/* mailbox API, version 1.2 VF requests */ +#define IXGBE_VF_GET_RETA 0x0a /* VF request for RETA */ + +/* GET_RETA request data indices within the mailbox */ +#define IXGBE_VF_RETA_SZ 1 /* Number of RETA DWs to bring */ +#define IXGBE_VF_RETA_OFFSET 2 /* Offset in RETA */ + /* length of permanent address message returned from PF */ #define IXGBE_VF_PERMADDR_MSG_LEN 4 /* word in permanent address message with the current multicast type */ diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c index c903ab2..4b7246f 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c @@ -440,6 +440,7 @@ static s32 ixgbe_set_vf_lpe(struct ixgbe_adapter *adapter, u32 *msgbuf, u32 vf) #endif /* CONFIG_FCOE */ switch (adapter->vfinfo[vf].vf_api) { case ixgbe_mbox_api_11: + case ixgbe_mbox_api_12: /* * Version 1.1 supports jumbo frames on VFs if PF has * jumbo frames enabled which means legacy VFs are @@ -907,6 +908,7 @@ static int ixgbe_negotiate_vf_api(struct ixgbe_adapter *adapter, switch (api) { case ixgbe_mbox_api_10: case ixgbe_mbox_api_11: + case ixgbe_mbox_api_12: adapter->vfinfo[vf].vf_api = api; return 0; default: @@ -930,6 +932,7 @@ static int ixgbe_get_vf_queues(struct ixgbe_adapter *adapter, switch (adapter->vfinfo[vf].vf_api) { case ixgbe_mbox_api_20: case ixgbe_mbox_api_11: + case ixgbe_mbox_api_12: break; default: return -1; @@ -957,6 +960,65 @@ static int ixgbe_get_vf_queues(struct ixgbe_adapter *adapter, return 0; } +static int ixgbe_get_vf_reta(struct ixgbe_adapter *adapter, u32 *msgbuf, u32 vf) +{ + struct ixgbe_hw *hw = &adapter->hw; + int i, j; + u32 *reta = &msgbuf[1]; + u32 mask = 0; + u32 psrtype; + u32 reta_offset_dw = msgbuf[IXGBE_VF_RETA_OFFSET]; + u32 dwords = msgbuf[IXGBE_VF_RETA_SZ]; + + /* verify the PF is supporting the correct API */ + if (!adapter->vfinfo[vf].rss_query_enabled || + (adapter->vfinfo[vf].vf_api != ixgbe_mbox_api_12)) + return -EPERM; + + psrtype = IXGBE_READ_REG(hw, IXGBE_PSRTYPE(vf)); + + /* The redirection table is composed as follows: + * 82598: 128 (8 bit wide) entries containing pair of 4 bit RSS indices + * 82599/X540: 128 (8 bit wide) entries containing 4 bit RSS index X550: + * 512 (8 bit wide) entries containing 6 bit RSS index + * + * PSRTYPE[n].RQPL defines if 0, 1 or 2 bits from the redirection table + * value should be used. + */ + + if ((psrtype & (1 << 29)) == (1 << 29)) + mask = 0x01010101; + else if ((psrtype & (2 << 29)) == (2 << 29)) + mask = 0x03030303; + else + mask = 0; + + switch (hw->mac.type) { + case ixgbe_mac_82599EB: + case ixgbe_mac_X540: + /* Read the appropriate portion of RETA */ + for (i = 0; i < dwords; i++) + reta[i] = IXGBE_READ_REG(hw, + IXGBE_RETA(i + reta_offset_dw)); + break; + case ixgbe_mac_X550: + case ixgbe_mac_X550EM_x: + /* X550 has a per-VF RETA */ + for (i = 0, j = reta_offset_dw; i < dwords; i++, j++) + reta[i] = IXGBE_READ_REG(hw, + IXGBE_PFVFRETA(j, vf)); + break; + default: + return -1; + } + + /* Mask the relevant bits */ + for (i = 0; i < dwords; i++) + reta[i] &= mask; + + return 0; +} + static int ixgbe_rcv_msg_from_vf(struct ixgbe_adapter *adapter, u32 vf) { u32 mbx_size = IXGBE_VFMAILBOX_SIZE; @@ -1013,6 +1075,9 @@ static int ixgbe_rcv_msg_from_vf(struct ixgbe_adapter *adapter, u32 vf) case IXGBE_VF_GET_QUEUES: retval = ixgbe_get_vf_queues(adapter, msgbuf, vf); break; + case IXGBE_VF_GET_RETA: + retval = ixgbe_get_vf_reta(adapter, msgbuf, vf); + break; default: e_err(drv, "Unhandled Msg %8.8x\n", msgbuf[0]); retval = IXGBE_ERR_MBX;