| Message ID | 1419297876-1412-1-git-send-email-wen.gang.wang@oracle.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On 2014/12/23 9:24, Wengang Wang wrote: > In __bond_release_one(), when the interface is not a slave or not a slave of > "this" master, it log error message. > > The message actually should be a debug message matching what bond_enslave() > does. > > Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com> > --- > drivers/net/bonding/bond_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c > index 184c434..0dceba1 100644 > --- a/drivers/net/bonding/bond_main.c > +++ b/drivers/net/bonding/bond_main.c > @@ -1648,7 +1648,7 @@ static int __bond_release_one(struct net_device *bond_dev, > /* slave is not a slave or master is not master of this slave */ > if (!(slave_dev->flags & IFF_SLAVE) || > !netdev_has_upper_dev(slave_dev, bond_dev)) { > - netdev_err(bond_dev, "cannot release %s\n", > + netdev_dbg(bond_dev, "cannot release %s\n", > slave_dev->name); > return -EINVAL; > } > Acked-by: Ding Tianhong <dingtianhong@huawei.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Dec 23, 2014 at 09:24:36AM +0800, Wengang Wang wrote: > In __bond_release_one(), when the interface is not a slave or not a slave of > "this" master, it log error message. > > The message actually should be a debug message matching what bond_enslave() > does. > > Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com> Signed-off-by: Andy Gospodarek <gospo@cumulusnetworks.com> > --- > drivers/net/bonding/bond_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c > index 184c434..0dceba1 100644 > --- a/drivers/net/bonding/bond_main.c > +++ b/drivers/net/bonding/bond_main.c > @@ -1648,7 +1648,7 @@ static int __bond_release_one(struct net_device *bond_dev, > /* slave is not a slave or master is not master of this slave */ > if (!(slave_dev->flags & IFF_SLAVE) || > !netdev_has_upper_dev(slave_dev, bond_dev)) { > - netdev_err(bond_dev, "cannot release %s\n", > + netdev_dbg(bond_dev, "cannot release %s\n", > slave_dev->name); > return -EINVAL; > } > -- > 1.8.3.1 > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Wengang Wang <wen.gang.wang@oracle.com> Date: Tue, 23 Dec 2014 09:24:36 +0800 > In __bond_release_one(), when the interface is not a slave or not a slave of > "this" master, it log error message. > > The message actually should be a debug message matching what bond_enslave() > does. > > Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 184c434..0dceba1 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -1648,7 +1648,7 @@ static int __bond_release_one(struct net_device *bond_dev, /* slave is not a slave or master is not master of this slave */ if (!(slave_dev->flags & IFF_SLAVE) || !netdev_has_upper_dev(slave_dev, bond_dev)) { - netdev_err(bond_dev, "cannot release %s\n", + netdev_dbg(bond_dev, "cannot release %s\n", slave_dev->name); return -EINVAL; }
In __bond_release_one(), when the interface is not a slave or not a slave of "this" master, it log error message. The message actually should be a debug message matching what bond_enslave() does. Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com> --- drivers/net/bonding/bond_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)