From patchwork Wed Nov 19 05:18:12 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wengang Wang X-Patchwork-Id: 412258 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 0FDB8140139 for ; Wed, 19 Nov 2014 16:16:49 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754292AbaKSFQn (ORCPT ); Wed, 19 Nov 2014 00:16:43 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:24627 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750853AbaKSFQm (ORCPT ); Wed, 19 Nov 2014 00:16:42 -0500 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id sAJ5Gdhp031581 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 19 Nov 2014 05:16:40 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id sAJ5GdKF028103 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Wed, 19 Nov 2014 05:16:39 GMT Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id sAJ5GdBJ028100; Wed, 19 Nov 2014 05:16:39 GMT Received: from oracle.com (/10.182.64.159) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 18 Nov 2014 21:16:38 -0800 From: Wengang Wang To: wwgwork@gmail.com, netdev@vger.kernel.org Cc: wen.gang.wang@oracle.com Subject: [PATCH] bonding: clear header_ops when last slave detached (v2) Date: Wed, 19 Nov 2014 13:18:12 +0800 Message-Id: <1416374292-10993-1-git-send-email-wen.gang.wang@oracle.com> X-Mailer: git-send-email 1.8.3.1 X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When last slave of a bonding master is removed, the bonding then does not work. When packet_snd is called against with a master net_device, it accesses header_ops. In case the header_ops is not valid any longer(say ipoib module unloaded), it will then access an invalid memory address. This patch try to fix this issue by clearing header_ops when last slave detached. Signed-off-by: Wengang Wang --- drivers/net/bonding/bond_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index c9ac06c..52a7e4b 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -1730,6 +1730,7 @@ static int __bond_release_one(struct net_device *bond_dev, bond->slave_cnt--; if (!bond_has_slaves(bond)) { + bond->dev->header_ops = NULL; call_netdevice_notifiers(NETDEV_CHANGEADDR, bond->dev); call_netdevice_notifiers(NETDEV_RELEASE, bond->dev); }