From patchwork Tue Nov 18 13:47:07 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 412043 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id CA541140179 for ; Wed, 19 Nov 2014 00:47:38 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754588AbaKRNrX (ORCPT ); Tue, 18 Nov 2014 08:47:23 -0500 Received: from mail-pd0-f169.google.com ([209.85.192.169]:46029 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754561AbaKRNrV (ORCPT ); Tue, 18 Nov 2014 08:47:21 -0500 Received: by mail-pd0-f169.google.com with SMTP id fp1so6039262pdb.14 for ; Tue, 18 Nov 2014 05:47:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=sWre5PzgedustsZ5ktfLYXwS/A1sQEqZNycaA9MJaIk=; b=zW0pwqlO9mvVoH4crrgn75VOidSOMU7bjbyo64c8zY8Rw8ldysvUKHLBZXmUVyL4Iz hJ4WnS52oiAtoTy0taA1NZB5j+RIX2EDSamFvfUF8obzER6wYVbcmpBeWQUfsWSOAR7m V5MDnZ/WwFWTLsudUREkgvgY+loTBwLS6UOWcInw4TEKaNz+2mlUYMUYNcnmpWA611/0 k9hu0Ei0yq9/IzZWQ4v865wBdFdPfVuV75jbTHOIi6JxU8OXArBKzl7CODY6MhQSaqRl WXrl6M+k0iKZ5Wsc/7U3xE81eRSzRW1gm+3YNseXid1cVwlnCqcHicT35Hi08xJjDaQl p/Yg== X-Received: by 10.70.134.74 with SMTP id pi10mr11724093pdb.126.1416318440934; Tue, 18 Nov 2014 05:47:20 -0800 (PST) Received: from localhost.localdomain ([122.169.182.195]) by mx.google.com with ESMTPSA id gy5sm37942164pbc.68.2014.11.18.05.47.17 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 18 Nov 2014 05:47:20 -0800 (PST) From: Sudip Mukherjee To: Wolfgang Grandegger , Marc Kleine-Budde , Michal Simek , =?UTF-8?q?S=C3=B6ren=20Brinkmann?= Cc: Sudip Mukherjee , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] net: can: comparison of unsigned variable Date: Tue, 18 Nov 2014 19:17:07 +0530 Message-Id: <1416318427-28676-2-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1416318427-28676-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1416318427-28676-1-git-send-email-sudipm.mukherjee@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org err was of the type u32. it was being compared with < 0, and being an unsigned variable the comparison would have been always false. moreover, err was getting the return value from set_reset_mode() and xcan_set_bittiming(), and both are returning int. Signed-off-by: Sudip Mukherjee Reviewed-by: Michal Simek --- drivers/net/can/xilinx_can.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c index 72fe96f..67c2dd4 100644 --- a/drivers/net/can/xilinx_can.c +++ b/drivers/net/can/xilinx_can.c @@ -300,7 +300,8 @@ static int xcan_set_bittiming(struct net_device *ndev) static int xcan_chip_start(struct net_device *ndev) { struct xcan_priv *priv = netdev_priv(ndev); - u32 err, reg_msr, reg_sr_mask; + u32 reg_msr, reg_sr_mask; + int err; unsigned long timeout; /* Check if it is in reset mode */