From patchwork Fri Nov 7 13:22:40 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 408114 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 5F62A1400D2 for ; Sat, 8 Nov 2014 00:23:28 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752799AbaKGNWx (ORCPT ); Fri, 7 Nov 2014 08:22:53 -0500 Received: from mail-pd0-f170.google.com ([209.85.192.170]:36854 "EHLO mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752621AbaKGNWu (ORCPT ); Fri, 7 Nov 2014 08:22:50 -0500 Received: by mail-pd0-f170.google.com with SMTP id z10so3329569pdj.29 for ; Fri, 07 Nov 2014 05:22:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=ZBXGm+Q6qwDGa8Yhj/S2pU0Nksr0U3ZL3LIUf2E9k4w=; b=LY85KUAayd8l74d8VO4t/Dn5zqjq3OBTyJ1Y1EJp4y2mhEIUdVnxsizyS5uGmfBfrF OS3mMOw8WcNaMAIRF8a3k0YtivfPaztW6gnZoqm1ltx/AGsUG4WzI2vu1qa4igl2WSXB hXScXoktx94cYHl6/iJwsUaMXsKtdksbKD0YFO78jBoRrOyF5XbTFMNRjBIYfHo1Jjje NJToU9ZacwueKWc1Svlnkla5cRbhJrNuo7iSa3lILbP0LXLLyiS0H5K/4zJMX+P36d7p XgfC/CJa9D5y01a3LVVx8vAJmUsq2/9JFKa5BXIEyIczMBPF/DQ4yAhwOWNdUY/Jnqob vv/w== X-Received: by 10.68.227.104 with SMTP id rz8mr12168494pbc.4.1415366570195; Fri, 07 Nov 2014 05:22:50 -0800 (PST) Received: from localhost.localdomain ([122.169.172.28]) by mx.google.com with ESMTPSA id d15sm2072573pbu.34.2014.11.07.05.22.47 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 07 Nov 2014 05:22:49 -0800 (PST) From: Sudip Mukherjee To: Steve Glendinning Cc: Sudip Mukherjee , netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] usbnet: smsc95xx: dereferencing NULL pointer Date: Fri, 7 Nov 2014 18:52:40 +0530 Message-Id: <1415366560-27614-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.8.1.2 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org we were dereferencing dev to initialize pdata. but just after that we have a BUG_ON(!dev). so we were basically dereferencing the pointer first and then tesing it for NULL. Signed-off-by: Sudip Mukherjee --- drivers/net/usb/smsc95xx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c index d07bf4c..3393238 100644 --- a/drivers/net/usb/smsc95xx.c +++ b/drivers/net/usb/smsc95xx.c @@ -1670,12 +1670,13 @@ done: static int smsc95xx_resume(struct usb_interface *intf) { struct usbnet *dev = usb_get_intfdata(intf); - struct smsc95xx_priv *pdata = (struct smsc95xx_priv *)(dev->data[0]); + struct smsc95xx_priv *pdata; u8 suspend_flags = pdata->suspend_flags; int ret; u32 val; BUG_ON(!dev); + pdata = (struct smsc95xx_priv *)(dev->data[0]); netdev_dbg(dev->net, "resume suspend_flags=0x%02x\n", suspend_flags);