From patchwork Mon Nov 3 12:12:29 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 406111 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6F86114007F for ; Mon, 3 Nov 2014 23:12:46 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751671AbaKCMMk (ORCPT ); Mon, 3 Nov 2014 07:12:40 -0500 Received: from mail-pa0-f51.google.com ([209.85.220.51]:60639 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751208AbaKCMMj (ORCPT ); Mon, 3 Nov 2014 07:12:39 -0500 Received: by mail-pa0-f51.google.com with SMTP id kq14so12062807pab.38 for ; Mon, 03 Nov 2014 04:12:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=83ySBwFr4xgWeGiv0THO3icSxvpSTuCrj7rgNg4ipJs=; b=BX/7XZdrBv6PdwCwuA36obR7zLXOUaLOW2++X6GyhRz2NyVbZPE4rwA+OzNLmdXGcU Knbe2IVG6y8Bkx07iRvbHZYwzdp5scymNmROA5HGW75fs4iOLL6JHW31Wx4sptvB0NzX Vu86KtCgcs5id70JExtC3s3O8+lF/1/mWk7iWjFm3O0/sy1642ghqvlmStgMBewvISE4 FQrYum7cZgwyCJFpu1HqduP4m8SgrNm7Oc0tcyU89e+18HPQ6FnepzfPE0SnpP9QVWOc HtYXgQQoKO5lUCgriZzmeQVlDQDnG30pvf2yXFRlgltaNyWvGU/cYr8H2ZXUt4GWR17L 0otg== X-Received: by 10.68.100.197 with SMTP id fa5mr43662346pbb.22.1415016758613; Mon, 03 Nov 2014 04:12:38 -0800 (PST) Received: from localhost.localdomain ([122.169.160.196]) by mx.google.com with ESMTPSA id pc8sm17079739pdb.54.2014.11.03.04.12.36 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 03 Nov 2014 04:12:38 -0800 (PST) From: Sudip Mukherjee To: Andreas Koensgen Cc: Sudip Mukherjee , linux-hams@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] hamradio: 6pack: remove unnecessary check Date: Mon, 3 Nov 2014 17:42:29 +0530 Message-Id: <1415016749-6825-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.8.1.2 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org this is check for dev is unnecessary, as we are already checking dev after allocating it via alloc_netdev, and jumping to label: out if it is NULL. Signed-off-by: Sudip Mukherjee --- drivers/net/hamradio/6pack.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/hamradio/6pack.c b/drivers/net/hamradio/6pack.c index c3c4051..daca0de 100644 --- a/drivers/net/hamradio/6pack.c +++ b/drivers/net/hamradio/6pack.c @@ -675,8 +675,7 @@ out_free: kfree(xbuff); kfree(rbuff); - if (dev) - free_netdev(dev); + free_netdev(dev); out: return err;