From patchwork Fri Oct 24 02:12:08 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Varka Bhadram X-Patchwork-Id: 402724 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 741A2140081 for ; Fri, 24 Oct 2014 13:14:48 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755191AbaJXCOn (ORCPT ); Thu, 23 Oct 2014 22:14:43 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:41351 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752190AbaJXCOm (ORCPT ); Thu, 23 Oct 2014 22:14:42 -0400 Received: by mail-pa0-f44.google.com with SMTP id et14so234456pad.3 for ; Thu, 23 Oct 2014 19:14:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6f1Z0pyXurJCs4jyM9GzXwxjC7LkhGEgaKtcZ6EyLW4=; b=iknJcH4rfBfPhLv0y3joGIzQT9RAWhs2o1A1wWPM49hqul3EUD7xv5nceKlA3t0WQ0 ASEzNMlFTVkZD5ZD41c2IUw0JH8NEPrCrpbN0q4D6QpPEsVz6DYeZpkPBHYrOnK+zgD2 Oojk9MfhCdIRBeoJy/Q9hCHULKLoCtLotq6I7nUK0wF4rXBEfgrkRUUecKBjaFfOYc+v rzIQv+4Bs/ULRwgQQfYxki4xYYIY4vIKiNEyLJtzruPxm8iYRvuoTTui8siw0SS25GeO 3P2gBkgqOgggnU486alkEgi75xmUlpbVRJEG+p2DoJCdH6Bhypk5WSS7scO19s1qMlSu 47gw== X-Received: by 10.70.134.138 with SMTP id pk10mr1386399pdb.59.1414116882350; Thu, 23 Oct 2014 19:14:42 -0700 (PDT) Received: from bujji.202.153.32.3 ([175.101.63.212]) by mx.google.com with ESMTPSA id xy3sm2603985pbb.38.2014.10.23.19.14.22 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 23 Oct 2014 19:14:40 -0700 (PDT) From: Varka Bhadram X-Google-Original-From: Varka Bhadram To: netdev@vger.kernel.org Cc: davem@davemloft.net, sergei.shtylyov@cogentembedded.com, Varka Bhadram Subject: [PATCH net-next v3 3/5] ethernet: marvell: remove unnecessary check Date: Fri, 24 Oct 2014 07:42:08 +0530 Message-Id: <1414116730-4590-4-git-send-email-varkab@cdac.in> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1414116730-4590-1-git-send-email-varkab@cdac.in> References: <1414116730-4590-1-git-send-email-varkab@cdac.in> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org devm_ioremap_resource checks platform_get_resource() return value. We can remove the duplicate check here. Signed-off-by: Varka Bhadram --- drivers/net/ethernet/marvell/pxa168_eth.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/marvell/pxa168_eth.c b/drivers/net/ethernet/marvell/pxa168_eth.c index c3b209c..a378c92 100644 --- a/drivers/net/ethernet/marvell/pxa168_eth.c +++ b/drivers/net/ethernet/marvell/pxa168_eth.c @@ -1505,16 +1505,14 @@ static int pxa168_eth_probe(struct platform_device *pdev) pep = netdev_priv(dev); pep->dev = dev; pep->clk = clk; + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (res == NULL) { - err = -ENODEV; - goto err_netdev; - } pep->base = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(pep->base)) { err = -ENOMEM; goto err_netdev; } + res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); BUG_ON(!res); dev->irq = res->start;