From patchwork Fri Oct 24 02:12:07 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Varka Bhadram X-Patchwork-Id: 402723 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id B4A9F140082 for ; Fri, 24 Oct 2014 13:14:36 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755149AbaJXCOW (ORCPT ); Thu, 23 Oct 2014 22:14:22 -0400 Received: from mail-pd0-f171.google.com ([209.85.192.171]:49706 "EHLO mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754764AbaJXCOV (ORCPT ); Thu, 23 Oct 2014 22:14:21 -0400 Received: by mail-pd0-f171.google.com with SMTP id r10so560739pdi.30 for ; Thu, 23 Oct 2014 19:14:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=snjAKDtHSP8Uv0QARJJOWPFDL55mOQ8g0FBAieuE0ys=; b=SBah9vUHYAuK75+DxT3UrHZzUw5/Pv2QjVDUXm34VMSX5VBm8Pkhk6FsyaUCW/PCXv GS8rZ9EzdxY9sUXNsDYX8prHnUbTse4E6HbQVg7pR/BxilwHJzw+7w0vj+mNEgYbd9pI FUEdrL4nUDtzVNL4UXqfJ7omwqZBXbJ5Y090PfFxpbmjMpMMrfQvmmoKDyKxqb1Zq1MH Iq/xaAqmA/sUYlYnjVFjDvY3ivq5EnzGglg5nylEn5G4G6olF/xIcXHUe9gGNJnLLPpa m/Jw/hSzFPxaOKLMyC00mPHkqy15aUtv2qCBkZDNvrOolUfXBa1iLex0uFlLNZG7MZlB Vf8A== X-Received: by 10.70.133.34 with SMTP id oz2mr1505553pdb.140.1414116860684; Thu, 23 Oct 2014 19:14:20 -0700 (PDT) Received: from bujji.202.153.32.3 ([175.101.63.212]) by mx.google.com with ESMTPSA id xy3sm2603985pbb.38.2014.10.23.19.14.03 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 23 Oct 2014 19:14:19 -0700 (PDT) From: Varka Bhadram X-Google-Original-From: Varka Bhadram To: netdev@vger.kernel.org Cc: davem@davemloft.net, sergei.shtylyov@cogentembedded.com, Varka Bhadram Subject: [PATCH net-next v3 2/5] ethernet: apm: xgene: remove unnecessary check Date: Fri, 24 Oct 2014 07:42:07 +0530 Message-Id: <1414116730-4590-3-git-send-email-varkab@cdac.in> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1414116730-4590-1-git-send-email-varkab@cdac.in> References: <1414116730-4590-1-git-send-email-varkab@cdac.in> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org devm_ioremap_resource checks platform_get_resource() return value. We can remove the duplicate check here. Signed-off-by: Varka Bhadram --- drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c index 3c208cc..f226594 100644 --- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c @@ -761,10 +761,6 @@ static int xgene_enet_get_resources(struct xgene_enet_pdata *pdata) ndev = pdata->ndev; res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "enet_csr"); - if (!res) { - dev_err(dev, "Resource enet_csr not defined\n"); - return -ENODEV; - } pdata->base_addr = devm_ioremap_resource(dev, res); if (IS_ERR(pdata->base_addr)) { dev_err(dev, "Unable to retrieve ENET Port CSR region\n"); @@ -772,10 +768,6 @@ static int xgene_enet_get_resources(struct xgene_enet_pdata *pdata) } res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ring_csr"); - if (!res) { - dev_err(dev, "Resource ring_csr not defined\n"); - return -ENODEV; - } pdata->ring_csr_addr = devm_ioremap_resource(dev, res); if (IS_ERR(pdata->ring_csr_addr)) { dev_err(dev, "Unable to retrieve ENET Ring CSR region\n"); @@ -783,10 +775,6 @@ static int xgene_enet_get_resources(struct xgene_enet_pdata *pdata) } res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ring_cmd"); - if (!res) { - dev_err(dev, "Resource ring_cmd not defined\n"); - return -ENODEV; - } pdata->ring_cmd_addr = devm_ioremap_resource(dev, res); if (IS_ERR(pdata->ring_cmd_addr)) { dev_err(dev, "Unable to retrieve ENET Ring command region\n");