From patchwork Thu Oct 23 01:58:49 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Varka Bhadram X-Patchwork-Id: 402327 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 65AC814007F for ; Thu, 23 Oct 2014 12:59:24 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932279AbaJWB7T (ORCPT ); Wed, 22 Oct 2014 21:59:19 -0400 Received: from mail-pd0-f179.google.com ([209.85.192.179]:45621 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932161AbaJWB7R (ORCPT ); Wed, 22 Oct 2014 21:59:17 -0400 Received: by mail-pd0-f179.google.com with SMTP id r10so102330pdi.24 for ; Wed, 22 Oct 2014 18:59:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6f1Z0pyXurJCs4jyM9GzXwxjC7LkhGEgaKtcZ6EyLW4=; b=ytZb8sVju2nNV8NYyCJeZ9FP3xND6FeVrUDpAlJBVVN9qZvTxBFeybJbFbWijflMMn Z0ZXfb3e3Nz3ftOVwAIUZ6vSx10ppP1XOHmTaVxOwvzxUZJXaK5SsEk5PJZkOCjObPPh WQDiJcHPM8+kojzSx26qvch0jdUX/mVXXftuBEaU3g04lZk6y+7uUbO+kx8DD1kVJRDW izXo5SkkycqVCWN+bN1y5Q/2YHn7Lt+OG2yPQBCK5ngf2oFkL+h4R3nyXbEk3hDoYLrW 7DrVsAzoejDV6egcHtdFN2CYijNaBEpScXBLWjQcLFYO954pZHDlCvJCkacpKKXBxixH 5K/g== X-Received: by 10.66.102.2 with SMTP id fk2mr244028pab.143.1414029557216; Wed, 22 Oct 2014 18:59:17 -0700 (PDT) Received: from bujji.202.153.32.3 ([175.101.63.212]) by mx.google.com with ESMTPSA id gu10sm251661pbc.72.2014.10.22.18.59.14 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 22 Oct 2014 18:59:15 -0700 (PDT) From: Varka Bhadram X-Google-Original-From: Varka Bhadram To: netdev@vger.kernel.org Cc: davem@davemloft.net, Varka Bhadram Subject: [PATCH net-next v2 4/6] ethernet: marvell: remove unnecessary check Date: Thu, 23 Oct 2014 07:28:49 +0530 Message-Id: <1414029531-5067-5-git-send-email-varkab@cdac.in> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1414029531-5067-1-git-send-email-varkab@cdac.in> References: <1414029531-5067-1-git-send-email-varkab@cdac.in> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org devm_ioremap_resource checks platform_get_resource() return value. We can remove the duplicate check here. Signed-off-by: Varka Bhadram --- drivers/net/ethernet/marvell/pxa168_eth.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/marvell/pxa168_eth.c b/drivers/net/ethernet/marvell/pxa168_eth.c index c3b209c..a378c92 100644 --- a/drivers/net/ethernet/marvell/pxa168_eth.c +++ b/drivers/net/ethernet/marvell/pxa168_eth.c @@ -1505,16 +1505,14 @@ static int pxa168_eth_probe(struct platform_device *pdev) pep = netdev_priv(dev); pep->dev = dev; pep->clk = clk; + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (res == NULL) { - err = -ENODEV; - goto err_netdev; - } pep->base = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(pep->base)) { err = -ENOMEM; goto err_netdev; } + res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); BUG_ON(!res); dev->irq = res->start;