From patchwork Thu Oct 23 01:58:48 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Varka Bhadram X-Patchwork-Id: 402330 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 110EA1400D6 for ; Thu, 23 Oct 2014 12:59:35 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932368AbaJWB7b (ORCPT ); Wed, 22 Oct 2014 21:59:31 -0400 Received: from mail-pd0-f176.google.com ([209.85.192.176]:41864 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932192AbaJWB7P (ORCPT ); Wed, 22 Oct 2014 21:59:15 -0400 Received: by mail-pd0-f176.google.com with SMTP id fp1so105737pdb.21 for ; Wed, 22 Oct 2014 18:59:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=snjAKDtHSP8Uv0QARJJOWPFDL55mOQ8g0FBAieuE0ys=; b=rNP1M0GO5foakSIn15N7+ljLlKwXuBe277qL8dmpGYhup/Ve+XhrpzAZ1vFnzeS/rH 8SprAHQRhupEoBl7ConbvP7O+HspcffEi9P6EpSx+FCXny59p9yj2o8cjWnHPJfrVuvU 5ccNy17/qyuNf9W50TwGO2rruAwXXWCWvCSwJrINV0zpRS6Z0L76mEbvl7sfQNZWgWtI V8ZWDXWo0y0J6RPmrRHrCvZTRvCbpJGIOsHhVpM2ji6fJJvr4S0PX5MJ8XJs1w7eNvh8 2QAX8Az/vhmTZhPdWkz3lt4mu/RWdq4zxVpFVpR5vNblyqb192UORxkqh8ZZPZpqWTgv +W9g== X-Received: by 10.66.252.8 with SMTP id zo8mr1921794pac.12.1414029554103; Wed, 22 Oct 2014 18:59:14 -0700 (PDT) Received: from bujji.202.153.32.3 ([175.101.63.212]) by mx.google.com with ESMTPSA id gu10sm251661pbc.72.2014.10.22.18.59.11 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 22 Oct 2014 18:59:12 -0700 (PDT) From: Varka Bhadram X-Google-Original-From: Varka Bhadram To: netdev@vger.kernel.org Cc: davem@davemloft.net, Varka Bhadram Subject: [PATCH net-next v2 3/6] ethernet: apm: xgene: remove unnecessary check Date: Thu, 23 Oct 2014 07:28:48 +0530 Message-Id: <1414029531-5067-4-git-send-email-varkab@cdac.in> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1414029531-5067-1-git-send-email-varkab@cdac.in> References: <1414029531-5067-1-git-send-email-varkab@cdac.in> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org devm_ioremap_resource checks platform_get_resource() return value. We can remove the duplicate check here. Signed-off-by: Varka Bhadram --- drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c index 3c208cc..f226594 100644 --- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c @@ -761,10 +761,6 @@ static int xgene_enet_get_resources(struct xgene_enet_pdata *pdata) ndev = pdata->ndev; res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "enet_csr"); - if (!res) { - dev_err(dev, "Resource enet_csr not defined\n"); - return -ENODEV; - } pdata->base_addr = devm_ioremap_resource(dev, res); if (IS_ERR(pdata->base_addr)) { dev_err(dev, "Unable to retrieve ENET Port CSR region\n"); @@ -772,10 +768,6 @@ static int xgene_enet_get_resources(struct xgene_enet_pdata *pdata) } res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ring_csr"); - if (!res) { - dev_err(dev, "Resource ring_csr not defined\n"); - return -ENODEV; - } pdata->ring_csr_addr = devm_ioremap_resource(dev, res); if (IS_ERR(pdata->ring_csr_addr)) { dev_err(dev, "Unable to retrieve ENET Ring CSR region\n"); @@ -783,10 +775,6 @@ static int xgene_enet_get_resources(struct xgene_enet_pdata *pdata) } res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ring_cmd"); - if (!res) { - dev_err(dev, "Resource ring_cmd not defined\n"); - return -ENODEV; - } pdata->ring_cmd_addr = devm_ioremap_resource(dev, res); if (IS_ERR(pdata->ring_cmd_addr)) { dev_err(dev, "Unable to retrieve ENET Ring command region\n");