From patchwork Thu Oct 23 01:58:47 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Varka Bhadram X-Patchwork-Id: 402326 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id F24C114007F for ; Thu, 23 Oct 2014 12:59:20 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932247AbaJWB7Q (ORCPT ); Wed, 22 Oct 2014 21:59:16 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:64165 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932161AbaJWB7M (ORCPT ); Wed, 22 Oct 2014 21:59:12 -0400 Received: by mail-pa0-f48.google.com with SMTP id ey11so100886pad.35 for ; Wed, 22 Oct 2014 18:59:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=m/pudVa7qGJpxlSsanGxSoo1zof66TMnbfKln9RI+g8=; b=BhjpPZTftAoF5T3Uld978cYdMqZ6avPz1uN59YOmmhYAdMm4YfmpCP8c2LZhR3BBVr rH+nV+fqo8fUc2eeD+CJoZNstFZtTsRAzMU9n6ha2gpQWWmwYPvMombqaelfChFq8mZn 7P4+Xl/n5XPODl5yBJDp1Zk7IdYDEz6OFN6jQTMJcWrg34fFGwwP0UtjxFMULDeiydCu t6XfID+QWxbYjnxAiKJepZJm9hLPsoCmUjaAv9x5EqB15kq+kgZcFCFZtRL+Z0pmISjM 2e25oBBF4czXDpNAwdDYvetVoTQvZ40DD9YjcR4NiXG2aT6bzKBEytBfnoQ8L5uy80pN CICg== X-Received: by 10.66.237.98 with SMTP id vb2mr236790pac.144.1414029550873; Wed, 22 Oct 2014 18:59:10 -0700 (PDT) Received: from bujji.202.153.32.3 ([175.101.63.212]) by mx.google.com with ESMTPSA id gu10sm251661pbc.72.2014.10.22.18.59.08 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 22 Oct 2014 18:59:09 -0700 (PDT) From: Varka Bhadram X-Google-Original-From: Varka Bhadram To: netdev@vger.kernel.org Cc: davem@davemloft.net, Varka Bhadram Subject: [PATCH net-next v2 2/6] ethernet: wiznet: remove unnecessary check Date: Thu, 23 Oct 2014 07:28:47 +0530 Message-Id: <1414029531-5067-3-git-send-email-varkab@cdac.in> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1414029531-5067-1-git-send-email-varkab@cdac.in> References: <1414029531-5067-1-git-send-email-varkab@cdac.in> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org devm_ioremap_resource checks platform_get_resource() return value. We can remove the duplicate check here. Signed-off-by: Varka Bhadram --- drivers/net/ethernet/wiznet/w5300.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/wiznet/w5300.c b/drivers/net/ethernet/wiznet/w5300.c index f961f14..7974b7d 100644 --- a/drivers/net/ethernet/wiznet/w5300.c +++ b/drivers/net/ethernet/wiznet/w5300.c @@ -558,14 +558,12 @@ static int w5300_hw_probe(struct platform_device *pdev) } mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!mem) - return -ENXIO; - mem_size = resource_size(mem); - priv->base = devm_ioremap_resource(&pdev->dev, mem); if (IS_ERR(priv->base)) return PTR_ERR(priv->base); + mem_size = resource_size(mem); + spin_lock_init(&priv->reg_lock); priv->indirect = mem_size < W5300_BUS_DIRECT_SIZE; if (priv->indirect) {