From patchwork Thu Oct 23 01:58:46 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Varka Bhadram X-Patchwork-Id: 402325 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6F5F314007F for ; Thu, 23 Oct 2014 12:59:15 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932122AbaJWB7J (ORCPT ); Wed, 22 Oct 2014 21:59:09 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:40905 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752801AbaJWB7I (ORCPT ); Wed, 22 Oct 2014 21:59:08 -0400 Received: by mail-pa0-f46.google.com with SMTP id fa1so119506pad.5 for ; Wed, 22 Oct 2014 18:59:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=N5HEXK+Dto8e2b/4/pa+rILdbg5WjvkiUXnnp9XcDS0=; b=AhBvbb0WSZGr20ZMAuW1cfNvN6cGtcECpOxyP2ASTZ7lYlyPPkhLSsTnbtesVejdhp TDOgNrBKSnBZC/anewprY2b3N9wMAkzNxK5ri+Xj46nCy+tc+jVaRI7eWPEKwulOj8if byo3tYEr6vAfCeTJyrQ0U7lmSVcdeZecT+Ykmlmzb5pj4ijs8F/2xENMTLXW2WzXlOoc W+jgzJt8NnmMW2uWpkofAo6OOTXwV8QQuPJeBjPpyuPZ/1eDUIqJV9FAlrbAuy0WCPNx 4dRYWJV40bLxoLqZQSXksC8UOPCU4bkpQR52vRo9CzYO1GqcmuYZvS61ivE9BIXd7fmj TALA== X-Received: by 10.68.226.226 with SMTP id rv2mr1685349pbc.77.1414029547903; Wed, 22 Oct 2014 18:59:07 -0700 (PDT) Received: from bujji.202.153.32.3 ([175.101.63.212]) by mx.google.com with ESMTPSA id gu10sm251661pbc.72.2014.10.22.18.59.05 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 22 Oct 2014 18:59:06 -0700 (PDT) From: Varka Bhadram X-Google-Original-From: Varka Bhadram To: netdev@vger.kernel.org Cc: davem@davemloft.net, Varka Bhadram Subject: [PATCH net-next v2 1/6] ethernet: wiznet: remove unnecessary check Date: Thu, 23 Oct 2014 07:28:46 +0530 Message-Id: <1414029531-5067-2-git-send-email-varkab@cdac.in> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1414029531-5067-1-git-send-email-varkab@cdac.in> References: <1414029531-5067-1-git-send-email-varkab@cdac.in> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org devm_ioremap_resource checks platform_get_resource() return value. We can remove the duplicate check here. Signed-off-by: Varka Bhadram --- drivers/net/ethernet/wiznet/w5100.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/wiznet/w5100.c b/drivers/net/ethernet/wiznet/w5100.c index 0f56b1c..70a930a 100644 --- a/drivers/net/ethernet/wiznet/w5100.c +++ b/drivers/net/ethernet/wiznet/w5100.c @@ -638,14 +638,12 @@ static int w5100_hw_probe(struct platform_device *pdev) } mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!mem) - return -ENXIO; - mem_size = resource_size(mem); - priv->base = devm_ioremap_resource(&pdev->dev, mem); if (IS_ERR(priv->base)) return PTR_ERR(priv->base); + mem_size = resource_size(mem); + spin_lock_init(&priv->reg_lock); priv->indirect = mem_size < W5100_BUS_DIRECT_SIZE; if (priv->indirect) {