| Message ID | 1413951386-29645-6-git-send-email-varkab@cdac.in |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On 10/22/2014 8:16 AM, Varka Bhadram wrote: > devm_ioremap_resource checks platform_get_resource() return value. > We can remove the duplicate check here. > Signed-off-by: Varka Bhadram <varkab@cdac.in> > --- > drivers/net/ethernet/renesas/sh_eth.c | 4 ---- > 1 file changed, 4 deletions(-) > diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c > index 60e9c2c..d824ba5 100644 > --- a/drivers/net/ethernet/renesas/sh_eth.c > +++ b/drivers/net/ethernet/renesas/sh_eth.c > @@ -2769,10 +2769,6 @@ static int sh_eth_drv_probe(struct platform_device *pdev) > > /* get base addr */ > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (unlikely(res == NULL)) { > - dev_err(&pdev->dev, "invalid resource\n"); > - return -EINVAL; > - } The driver dereferences 'res' further on, so you can't remove this check. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/22/2014 05:17 PM, Sergei Shtylyov wrote: > On 10/22/2014 8:16 AM, Varka Bhadram wrote: > >> devm_ioremap_resource checks platform_get_resource() return value. >> We can remove the duplicate check here. > >> Signed-off-by: Varka Bhadram <varkab@cdac.in> >> --- >> drivers/net/ethernet/renesas/sh_eth.c | 4 ---- >> 1 file changed, 4 deletions(-) > >> diff --git a/drivers/net/ethernet/renesas/sh_eth.c >> b/drivers/net/ethernet/renesas/sh_eth.c >> index 60e9c2c..d824ba5 100644 >> --- a/drivers/net/ethernet/renesas/sh_eth.c >> +++ b/drivers/net/ethernet/renesas/sh_eth.c >> @@ -2769,10 +2769,6 @@ static int sh_eth_drv_probe(struct >> platform_device *pdev) >> >> /* get base addr */ >> res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> - if (unlikely(res == NULL)) { >> - dev_err(&pdev->dev, "invalid resource\n"); >> - return -EINVAL; >> - } > > The driver dereferences 'res' further on, so you can't remove this > check. > Yes its my mistake . I will fix it . Thankx > WBR, Sergei >
diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index 60e9c2c..d824ba5 100644 --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c @@ -2769,10 +2769,6 @@ static int sh_eth_drv_probe(struct platform_device *pdev) /* get base addr */ res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (unlikely(res == NULL)) { - dev_err(&pdev->dev, "invalid resource\n"); - return -EINVAL; - } ndev = alloc_etherdev(sizeof(struct sh_eth_private)); if (!ndev)
devm_ioremap_resource checks platform_get_resource() return value. We can remove the duplicate check here. Signed-off-by: Varka Bhadram <varkab@cdac.in> --- drivers/net/ethernet/renesas/sh_eth.c | 4 ---- 1 file changed, 4 deletions(-)