From patchwork Wed Oct 22 04:16:24 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Varka Bhadram X-Patchwork-Id: 401882 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id B5EB2140076 for ; Wed, 22 Oct 2014 15:20:02 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932092AbaJVETp (ORCPT ); Wed, 22 Oct 2014 00:19:45 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:43254 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753142AbaJVETn (ORCPT ); Wed, 22 Oct 2014 00:19:43 -0400 Received: by mail-pa0-f48.google.com with SMTP id ey11so851457pad.7 for ; Tue, 21 Oct 2014 21:19:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6f1Z0pyXurJCs4jyM9GzXwxjC7LkhGEgaKtcZ6EyLW4=; b=w4+zYoqtjIfb2tkqaWq+x+e1sDf2qia8szhj77hBr4uPAAqDXj3X3DsuLGhM+HLcZ8 ZY0/XKQWOX/pqcy8ZdaZsgISFCLOewUxSUchkXxtrkIVG90dBoe23iET+8zC7H8syr6O T/HS4fsXrMkSZB9/WqyZ7nJec8+2cyNRR3n+9M4ex1Tu3Fy/65CJMcnFkSy0JwPTZfKY z/usC2NfMWjFinBn+isyNqyoxqUoIT5P1i5S1VleZhj62ZKRUHYiNwtM3l/BWN7+bjtW ZD4u2QR8SPynXh6cgcMytkLKKly60OorYC0DF56S7DGyxN8fMSY+fKN8ss2y8LgoA+qV bwwA== X-Received: by 10.70.108.232 with SMTP id hn8mr32095225pdb.76.1413951583065; Tue, 21 Oct 2014 21:19:43 -0700 (PDT) Received: from cdac.hyderabad.cdac.in ([196.12.45.164]) by mx.google.com with ESMTPSA id g3sm13254243pdh.33.2014.10.21.21.19.39 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 21 Oct 2014 21:19:42 -0700 (PDT) From: Varka Bhadram X-Google-Original-From: Varka Bhadram To: netdev@vger.kernel.org Cc: Varka Bhadram Subject: [PATCH net-next 4/6] ethernet: marvell: remove unnecessary check Date: Wed, 22 Oct 2014 09:46:24 +0530 Message-Id: <1413951386-29645-5-git-send-email-varkab@cdac.in> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1413951386-29645-1-git-send-email-varkab@cdac.in> References: <1413951386-29645-1-git-send-email-varkab@cdac.in> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org devm_ioremap_resource checks platform_get_resource() return value. We can remove the duplicate check here. Signed-off-by: Varka Bhadram --- drivers/net/ethernet/marvell/pxa168_eth.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/marvell/pxa168_eth.c b/drivers/net/ethernet/marvell/pxa168_eth.c index c3b209c..a378c92 100644 --- a/drivers/net/ethernet/marvell/pxa168_eth.c +++ b/drivers/net/ethernet/marvell/pxa168_eth.c @@ -1505,16 +1505,14 @@ static int pxa168_eth_probe(struct platform_device *pdev) pep = netdev_priv(dev); pep->dev = dev; pep->clk = clk; + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (res == NULL) { - err = -ENODEV; - goto err_netdev; - } pep->base = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(pep->base)) { err = -ENOMEM; goto err_netdev; } + res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); BUG_ON(!res); dev->irq = res->start;