From patchwork Wed Aug 20 22:17:53 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Einon X-Patchwork-Id: 381832 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6794F14011D for ; Thu, 21 Aug 2014 08:20:20 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753301AbaHTWSQ (ORCPT ); Wed, 20 Aug 2014 18:18:16 -0400 Received: from mail-wg0-f50.google.com ([74.125.82.50]:33878 "EHLO mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753123AbaHTWSN (ORCPT ); Wed, 20 Aug 2014 18:18:13 -0400 Received: by mail-wg0-f50.google.com with SMTP id n12so8526486wgh.9 for ; Wed, 20 Aug 2014 15:18:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=v7ClF5iNvrAy3R0BiVC210Gid+9+Jkfw7bEbqn7/OMY=; b=aa2SFHEe+InVQ4hFnoqdovWOF0Uqdx9cJq9CKje8ioXJs/PJaHH2QBs0LhwDgw8ISX ZGWKSVHyARLlhZAA5SYVfgHf9rbcsPcaSDW028TZWOyIt6SNKbd9xn421skWpMiEVW2+ VAmfP5V7ymJ1/vw/rj2NvKqfN12KvNuF1gYWh00iWYJrCJEwg8pH0jcCjAhYQB2krnCm E1lqQTpwm+9wVRpiZqShP9ffqtly3BVCIqePF+mPrQYYvCUMNb2dMfm7GgsOZqgMOo4K JYGRPuuppcMHSsDiSCfDvggM8nJNoouXeM4GyfLveA20RWmrmz0Iz6KCrYX09N7GDi/S bxkw== X-Received: by 10.181.5.3 with SMTP id ci3mr18873732wid.57.1408573092486; Wed, 20 Aug 2014 15:18:12 -0700 (PDT) Received: from msilap.einon.net ([80.229.23.162]) by mx.google.com with ESMTPSA id f3sm13378073wiz.0.2014.08.20.15.18.11 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 20 Aug 2014 15:18:11 -0700 (PDT) From: Mark Einon To: gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Mark Einon Subject: [PATCH 3/8] staging: et131x: Use for loop to initialise contiguous registers to zero Date: Wed, 20 Aug 2014 23:17:53 +0100 Message-Id: <1408573078-9320-4-git-send-email-mark.einon@gmail.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1408573078-9320-1-git-send-email-mark.einon@gmail.com> References: <1408573078-9320-1-git-send-email-mark.einon@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Replace a long list of contiguous writel() calls with a for loop iterating over the same values. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 27 +++------------------------ 1 file changed, 3 insertions(+), 24 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index fffe763..44cc684 100644 --- a/drivers/staging/et131x/et131x.c +++ b/drivers/staging/et131x/et131x.c @@ -1138,6 +1138,7 @@ static void et1310_config_rxmac_regs(struct et131x_adapter *adapter) u32 sa_lo; u32 sa_hi = 0; u32 pf_ctrl = 0; + u32 *wolw; /* Disable the MAC while it is being configured (also disable WOL) */ writel(0x8, &rxmac->ctrl); @@ -1151,30 +1152,8 @@ static void et1310_config_rxmac_regs(struct et131x_adapter *adapter) * its default Values of 0x00000000 because there are not WOL masks * as of this time. */ - writel(0, &rxmac->mask0_word0); - writel(0, &rxmac->mask0_word1); - writel(0, &rxmac->mask0_word2); - writel(0, &rxmac->mask0_word3); - - writel(0, &rxmac->mask1_word0); - writel(0, &rxmac->mask1_word1); - writel(0, &rxmac->mask1_word2); - writel(0, &rxmac->mask1_word3); - - writel(0, &rxmac->mask2_word0); - writel(0, &rxmac->mask2_word1); - writel(0, &rxmac->mask2_word2); - writel(0, &rxmac->mask2_word3); - - writel(0, &rxmac->mask3_word0); - writel(0, &rxmac->mask3_word1); - writel(0, &rxmac->mask3_word2); - writel(0, &rxmac->mask3_word3); - - writel(0, &rxmac->mask4_word0); - writel(0, &rxmac->mask4_word1); - writel(0, &rxmac->mask4_word2); - writel(0, &rxmac->mask4_word3); + for (wolw = &rxmac->mask0_word0; wolw <= &rxmac->mask4_word3; wolw++) + writel(0, wolw); /* Lets setup the WOL Source Address */ sa_lo = (adapter->addr[2] << ET_RX_WOL_LO_SA3_SHIFT) |