From patchwork Wed Aug 20 22:17:52 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Einon X-Patchwork-Id: 381830 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 031FD14012F for ; Thu, 21 Aug 2014 08:19:42 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753348AbaHTWSR (ORCPT ); Wed, 20 Aug 2014 18:18:17 -0400 Received: from mail-we0-f177.google.com ([74.125.82.177]:34590 "EHLO mail-we0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753263AbaHTWSM (ORCPT ); Wed, 20 Aug 2014 18:18:12 -0400 Received: by mail-we0-f177.google.com with SMTP id w62so8540399wes.22 for ; Wed, 20 Aug 2014 15:18:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=VG3IgGg0fdICa/Gg15hMsf2rKjmSsv8Q/o+gS4GWM7E=; b=g1ws8lCebXvyMxEMkzf+fNAtVfnDFjgj8B3U8lFulB65ICZKYjC6/8Kc2MUhr7PDU/ t5LaliOR0xbEc36nOmqrNpM1AMC7FSUYc5oYj08N5Tdq1Kn6HQlMcn/mcurzzg8Byw9g X2UPF+e7kpiH60j8hXTaxaP4i9YKAMWjTkpWoF3wcUZWW2dT9dofpn34dZB/z9rXKJA7 2+3HDSUs4YBaS1qjxdprhIXm82hUyklUTMMN8Bj5eIKHwXUq0O0UveQSnC3zsgXA4Na6 nkVZsH3rHCClA3wDPEVaSmL9V+G3/SsQHIh5G6Lxu6I/VLy86A8G13CV23+P69ZnFCeU r1ew== X-Received: by 10.180.81.103 with SMTP id z7mr18101468wix.23.1408573091227; Wed, 20 Aug 2014 15:18:11 -0700 (PDT) Received: from msilap.einon.net ([80.229.23.162]) by mx.google.com with ESMTPSA id f3sm13378073wiz.0.2014.08.20.15.18.10 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 20 Aug 2014 15:18:10 -0700 (PDT) From: Mark Einon To: gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Mark Einon Subject: [PATCH 2/8] staging: et131x: Don't handle rx/tx packets when changing mtu Date: Wed, 20 Aug 2014 23:17:52 +0100 Message-Id: <1408573078-9320-3-git-send-email-mark.einon@gmail.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1408573078-9320-1-git-send-email-mark.einon@gmail.com> References: <1408573078-9320-1-git-send-email-mark.einon@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org There's no need to handle any rx/tx interrupts in the middle of an mtu change, so don't. After this change, receive and transmit interrupts are only handled in one place, which paves the way to using NAPI. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index ac6700b..fffe763 100644 --- a/drivers/staging/et131x/et131x.c +++ b/drivers/staging/et131x/et131x.c @@ -4434,8 +4434,6 @@ static int et131x_change_mtu(struct net_device *netdev, int new_mtu) return -EINVAL; et131x_disable_txrx(netdev); - et131x_handle_send_interrupt(adapter); - et131x_handle_recv_interrupt(adapter); /* Set the new MTU */ netdev->mtu = new_mtu;