From patchwork Wed Aug 20 09:31:43 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhu Yanjun X-Patchwork-Id: 381596 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A160414013B for ; Wed, 20 Aug 2014 19:33:00 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752129AbaHTJcF (ORCPT ); Wed, 20 Aug 2014 05:32:05 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:48678 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750864AbaHTJcD (ORCPT ); Wed, 20 Aug 2014 05:32:03 -0400 Received: by mail-pa0-f52.google.com with SMTP id bj1so11926413pad.25 for ; Wed, 20 Aug 2014 02:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=SShNy7w0O2DQPdCjNZkO4OUdkdarivPBIvbA5kcynwo=; b=piHYYyw0sg5tO0dJBPgfgnJUN5Z34fArWxVWincOSnGiC0XdarmrA03zlJPisliC5Z dyYQjYp/OQnjCkkk0cY3zfUnbjuL7PlSz/OPd4xIW1oJNqiDo/FmV/K4KvCR84R05uNF QfvxZzH1zchqIFZynqhJb5NFfyz3uJXNPBfzbT+n1B4OdpLOMRkGJzqiYNRyIBMGshLi LL8YmsWm5tjjSq8387RbYQInyZIm1iSNt+YeKAgDT/XNLfBV06zyhuT4sQm7KiK7TiZm dh5sQbXt4jbAZA5QpUDg2zlUyvlasxAScPvjLEPX92rz2XSpd8r6EGAlW6jYhlzeWj93 p/DQ== X-Received: by 10.69.18.234 with SMTP id gp10mr51528874pbd.11.1408527122375; Wed, 20 Aug 2014 02:32:02 -0700 (PDT) Received: from wind-OptiPlex-780.corp.ad.wrs.com ([1.202.252.122]) by mx.google.com with ESMTPSA id c10sm4026101pdk.47.2014.08.20.02.31.57 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 20 Aug 2014 02:32:01 -0700 (PDT) From: Zhu Yanjun X-Google-Original-From: Zhu Yanjun To: dborkman@redhat.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, vyasevich@gmail.com, tuexen@fh-muenster.de, khandelwal.deepak.1987@gmail.com, Yue.Tao@windriver.com, alexandre.dietsch@windriver.com, davem@davemloft.net, zyjzyj2000@gmail.com Cc: Zhu Yanjun Subject: [PATCH 1/1] sctp: not send SCTP_PEER_ADDR_CHANGE notifications with failed probe Date: Wed, 20 Aug 2014 17:31:43 +0800 Message-Id: <1408527103-22772-2-git-send-email-Yanjun.Zhu@windriver.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1408527103-22772-1-git-send-email-Yanjun.Zhu@windriver.com> References: <1408527103-22772-1-git-send-email-Yanjun.Zhu@windriver.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Since the transport has always been in state SCTP_UNCONFIRMED, it therefore wasn't active before and hasn't been used before, and it always has been, so it is unnecessary to bug the user with a notification. Reported-by: Deepak Khandelwal Suggested-by: Vlad Yasevich Suggested-by: Michael Tuexen Suggested-by: Daniel Borkmann Signed-off-by: Zhu Yanjun Acked-by: Vlad Yasevich Acked-by: Daniel Borkmann --- net/sctp/associola.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sctp/associola.c b/net/sctp/associola.c index 9de23a2..2e23f6b 100644 --- a/net/sctp/associola.c +++ b/net/sctp/associola.c @@ -813,6 +813,7 @@ void sctp_assoc_control_transport(struct sctp_association *asoc, else { dst_release(transport->dst); transport->dst = NULL; + ulp_notify = false; } spc_state = SCTP_ADDR_UNREACHABLE;