Message ID | 1407237222-3148-1-git-send-email-festevam@gmail.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Fabio Estevam <festevam@gmail.com> Date: Tue, 5 Aug 2014 08:13:42 -0300 > From: Fabio Estevam <fabio.estevam@freescale.com> > > Commit a71e3c37960ce5f9 ("net: phy: Set the driver when registering an MDIO bus > device") caused the following regression on the fec driver: ... > The problem with the original commit is explained by Russell King: > > "It has the effect (as can be seen from the oops) of attaching the MDIO bus > device (itself is a bus-less device) to the platform driver, which means > that if the platform driver supports power management, it will be called > to power manage the MDIO bus device. > > Moreover, drivers do not expect to be called for power management > operations for devices which they haven't probed, and certainly not for > devices which aren't part of the same bus that the driver is registered > against." > > This reverts commit a71e3c37960ce5f9c6a519bc1215e3ba9fa83e75. > > Cc: <stable@vger.kernel.org> #3.16 > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Applied, and queued up for -stable, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index 203651e..4eaadcf 100644 --- a/drivers/net/phy/mdio_bus.c +++ b/drivers/net/phy/mdio_bus.c @@ -255,7 +255,6 @@ int mdiobus_register(struct mii_bus *bus) bus->dev.parent = bus->parent; bus->dev.class = &mdio_bus_class; - bus->dev.driver = bus->parent->driver; bus->dev.groups = NULL; dev_set_name(&bus->dev, "%s", bus->id);