From patchwork Fri Jul 18 15:33:58 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Utkin X-Patchwork-Id: 371618 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 735591400B6 for ; Sat, 19 Jul 2014 01:34:40 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422685AbaGRPeU (ORCPT ); Fri, 18 Jul 2014 11:34:20 -0400 Received: from mail-la0-f46.google.com ([209.85.215.46]:41909 "EHLO mail-la0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030215AbaGRPeR (ORCPT ); Fri, 18 Jul 2014 11:34:17 -0400 Received: by mail-la0-f46.google.com with SMTP id b8so2951238lan.5 for ; Fri, 18 Jul 2014 08:34:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=w7RFpWuyOu0CQ1nkLwgx+Cgx6q1nvm7hyvZAZsyjYYk=; b=eQ9Pw0M80y6aWW7mZa0t6QIMYxdHSZJQb+yRgXED1+9Xyxi5Yr+TadHs47ZtMZnBOW m4+9Nika+aKZk97IQvL2VojmvMQ2JuXmW8hk+0xiqsKmwh6+Trl+d0RahOkTkd6hY4VF 9pPu9LAccRoncMIM76V/40rD/nheNdyvB2u0hyzURU0/7RYsptpXrRHW2IxcWXOdKx/J CsgIVP/Tdxkl8iby5vAw4PP3VV1ddaEK7QlE0gTlRNJdvgXiD83+fLmKjhlwOcOVSbOv 0GSzjvfVJWYyWvhIbRc1xVvwl1cWOeuxlPta1ULZEykSvD2jalKXofxI9puYou/DnVkf 8Rcg== X-Received: by 10.112.134.40 with SMTP id ph8mr5883646lbb.34.1405697655211; Fri, 18 Jul 2014 08:34:15 -0700 (PDT) Received: from localhost.localdomain (alfa-g11.tenet.odessa.ua. [195.138.73.151]) by mx.google.com with ESMTPSA id d8sm4777999lag.41.2014.07.18.08.34.13 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Jul 2014 08:34:14 -0700 (PDT) From: Andrey Utkin To: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, coreteam@netfilter.org, netfilter-devel@vger.kernel.org, lvs-devel@vger.kernel.org, netdev@vger.kernel.org Cc: dcb314@hotmail.com, davem@davemloft.net, kadlec@blackhole.kfki.hu, kaber@trash.net, pablo@netfilter.org, ja@ssi.bg, horms@verge.net.au, wensong@linux-vs.org, Andrey Utkin Subject: [PATCH 3/5] net/netfilter/ipvs/ip_vs_ctl.c: drop argument range check just before the check for equality Date: Fri, 18 Jul 2014 18:33:58 +0300 Message-Id: <1405697638-23767-1-git-send-email-andrey.krieger.utkin@gmail.com> X-Mailer: git-send-email 1.8.5.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80601 Reported-by: David Binderman Signed-off-by: Andrey Utkin --- net/netfilter/ipvs/ip_vs_ctl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c index 581a658..4ed7b59 100644 --- a/net/netfilter/ipvs/ip_vs_ctl.c +++ b/net/netfilter/ipvs/ip_vs_ctl.c @@ -2338,8 +2338,6 @@ do_ip_vs_set_ctl(struct sock *sk, int cmd, void __user *user, unsigned int len) if (cmd < IP_VS_BASE_CTL || cmd > IP_VS_SO_SET_MAX) return -EINVAL; - if (len < 0 || len > MAX_ARG_LEN) - return -EINVAL; if (len != set_arglen[SET_CMDID(cmd)]) { pr_err("set_ctl: len %u != %u\n", len, set_arglen[SET_CMDID(cmd)]);