From patchwork Fri Jul 18 15:31:57 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Utkin X-Patchwork-Id: 371614 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 26CFF1400AB for ; Sat, 19 Jul 2014 01:32:57 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030492AbaGRPcN (ORCPT ); Fri, 18 Jul 2014 11:32:13 -0400 Received: from mail-lb0-f172.google.com ([209.85.217.172]:39723 "EHLO mail-lb0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030485AbaGRPcL (ORCPT ); Fri, 18 Jul 2014 11:32:11 -0400 Received: by mail-lb0-f172.google.com with SMTP id z11so3026023lbi.3 for ; Fri, 18 Jul 2014 08:32:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=RbJNEYCN+4Zh9Mubf61HW1UwdGTI/Pa52q+inMqYteA=; b=JyD4qTz1BYCSTjOAG9UoRNQlm0GWHQMKHKNiZXIri9xAGpD2vEvtoiRWS3JZ5i0Sq6 IWsl6gezgvPL+vP76Wcin1IwgKW8uVqNCsqk+ZvwrJwWsHZ7yKY/2HevoK2h1IAy5YsB UHtbCcDknTsk+MiUj8JIpvb4IWLuW3g+gy//BhCcKQ3XMTct/EtQVB8q2rYEqmXpASaO cIWVBEkMxpkM0+Y84rXDjJuEnnr9M1YiFuvk7dz4Pu6qP2saxgLeei35kAeH+aluZJXH MYlJ780u7zh1KjMirkphL4CehHIOgf90zYZZFLpghwg1EBWaNZIYLMbHc0DMpUwIkNXi nW4A== X-Received: by 10.112.159.200 with SMTP id xe8mr5817145lbb.55.1405697529692; Fri, 18 Jul 2014 08:32:09 -0700 (PDT) Received: from localhost.localdomain (alfa-g11.tenet.odessa.ua. [195.138.73.151]) by mx.google.com with ESMTPSA id nd3sm9873997lbc.7.2014.07.18.08.32.07 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Jul 2014 08:32:08 -0700 (PDT) From: Andrey Utkin To: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, netdev@vger.kernel.org Cc: dcb314@hotmail.com, nwf@cs.jhu.edu, dhowells@redhat.com, davem@davemloft.net, Andrey Utkin Subject: [PATCH 2/5] net/rxrpc/ar-key.c: drop negativity check on unsigned value Date: Fri, 18 Jul 2014 18:31:57 +0300 Message-Id: <1405697517-23673-1-git-send-email-andrey.krieger.utkin@gmail.com> X-Mailer: git-send-email 1.8.5.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80611 Reported-by: David Binderman Signed-off-by: Andrey Utkin --- net/rxrpc/ar-key.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rxrpc/ar-key.c b/net/rxrpc/ar-key.c index 0ad0807..eec998e 100644 --- a/net/rxrpc/ar-key.c +++ b/net/rxrpc/ar-key.c @@ -346,7 +346,7 @@ static int rxrpc_krb5_decode_tagged_array(struct krb5_tagged_data **_td, n_elem = ntohl(*xdr++); toklen -= 4; - if (n_elem < 0 || n_elem > max_n_elem) + if (n_elem > max_n_elem) return -EINVAL; *_n_elem = n_elem; if (n_elem > 0) {